KVM: s390: always set/clear the SCA sda field

Let's always set and clear the sda when enabling/disabling a VCPU.
Dealing with sda being set to something else makes no sense anymore
as we enable a VCPU in the SCA now after it has been registered at
the VM.

Signed-off-by: David Hildenbrand <dahi@linux.vnet.ibm.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>

diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
index 2ba5978829f6d8a81fb461b34fa1305996faf314..7e0092bea6e9e022c8dcffa92062d8707fcaa003 100644 (file)
--- a/arch/s390/kvm/kvm-s390.c
+++ b/arch/s390/kvm/kvm-s390.c
@@ -1266,14 +1266,12 @@ static void sca_del_vcpu(struct kvm_vcpu *vcpu)
                struct esca_block *sca = vcpu->kvm->arch.sca;
 
                clear_bit_inv(vcpu->vcpu_id, (unsigned long *) sca->mcn);
-               if (sca->cpu[vcpu->vcpu_id].sda == (__u64) vcpu->arch.sie_block)
-                       sca->cpu[vcpu->vcpu_id].sda = 0;
+               sca->cpu[vcpu->vcpu_id].sda = 0;
        } else {
                struct bsca_block *sca = vcpu->kvm->arch.sca;
 
                clear_bit_inv(vcpu->vcpu_id, (unsigned long *) &sca->mcn);
-               if (sca->cpu[vcpu->vcpu_id].sda == (__u64) vcpu->arch.sie_block)
-                       sca->cpu[vcpu->vcpu_id].sda = 0;
+               sca->cpu[vcpu->vcpu_id].sda = 0;
        }
        read_unlock(&vcpu->kvm->arch.sca_lock);
 }
@@ -1285,8 +1283,7 @@ static void sca_add_vcpu(struct kvm_vcpu *vcpu, struct kvm *kvm,
        if (kvm->arch.use_esca) {
                struct esca_block *sca = kvm->arch.sca;
 
-               if (!sca->cpu[id].sda)
-                       sca->cpu[id].sda = (__u64) vcpu->arch.sie_block;
+               sca->cpu[id].sda = (__u64) vcpu->arch.sie_block;
                vcpu->arch.sie_block->scaoh = (__u32)(((__u64)sca) >> 32);
                vcpu->arch.sie_block->scaol = (__u32)(__u64)sca & ~0x3fU;
                vcpu->arch.sie_block->ecb2 |= 0x04U;
@@ -1294,8 +1291,7 @@ static void sca_add_vcpu(struct kvm_vcpu *vcpu, struct kvm *kvm,
        } else {
                struct bsca_block *sca = kvm->arch.sca;
 
-               if (!sca->cpu[id].sda)
-                       sca->cpu[id].sda = (__u64) vcpu->arch.sie_block;
+               sca->cpu[id].sda = (__u64) vcpu->arch.sie_block;
                vcpu->arch.sie_block->scaoh = (__u32)(((__u64)sca) >> 32);
                vcpu->arch.sie_block->scaol = (__u32)(__u64)sca;
                set_bit_inv(id, (unsigned long *) &sca->mcn);