]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
net/smc: delete pointless divide by one
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 8 Jan 2025 09:26:06 +0000 (12:26 +0300)
committerJakub Kicinski <kuba@kernel.org>
Sat, 11 Jan 2025 21:08:54 +0000 (13:08 -0800)
Here "buf" is a void pointer so sizeof(*buf) is one.  Doing a divide
by one makes the code less readable.  Delete it.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Link: https://patch.msgid.link/ee1a790b-f874-4512-b3ae-9c45f99dc640@stanley.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/smc/smc_core.c
net/smc/smc_rx.c

index ccf57b7fe602e5cd21c3337cca825f411e715a5f..ac07b963aedec18564e4e9680597930da72e7a5b 100644 (file)
@@ -2155,7 +2155,7 @@ static int smcr_buf_map_link(struct smc_buf_desc *buf_desc, bool is_rmb,
                for_each_sg(buf_desc->sgt[lnk->link_idx].sgl, sg, nents, i) {
                        size = min_t(int, PAGE_SIZE - offset, buf_size);
                        sg_set_page(sg, vmalloc_to_page(buf), size, offset);
-                       buf += size / sizeof(*buf);
+                       buf += size;
                        buf_size -= size;
                        offset = 0;
                }
index f0cbe77a80b44046b880e5a7107f535507c76c7c..e0ff6ed830576bf04018e8aeb36c6815b1db77e1 100644 (file)
@@ -197,7 +197,7 @@ static int smc_rx_splice(struct pipe_inode_info *pipe, char *src, size_t len,
                        partial[i].offset = offset;
                        partial[i].len = size;
                        partial[i].private = (unsigned long)priv[i];
-                       buf += size / sizeof(*buf);
+                       buf += size;
                        left -= size;
                        offset = 0;
                }