]> www.infradead.org Git - users/hch/misc.git/commitdiff
mptcp: Call dst_release() in mptcp_active_enable().
authorKuniyuki Iwashima <kuniyu@google.com>
Tue, 16 Sep 2025 21:47:24 +0000 (21:47 +0000)
committerJakub Kicinski <kuba@kernel.org>
Thu, 18 Sep 2025 01:10:22 +0000 (18:10 -0700)
mptcp_active_enable() calls sk_dst_get(), which returns dst with its
refcount bumped, but forgot dst_release().

Let's add missing dst_release().

Cc: stable@vger.kernel.org
Fixes: 27069e7cb3d1 ("mptcp: disable active MPTCP in case of blackhole")
Signed-off-by: Kuniyuki Iwashima <kuniyu@google.com>
Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://patch.msgid.link/20250916214758.650211-7-kuniyu@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/mptcp/ctrl.c

index fed40dae5583a35914da2cb1c52f37830d72705e..c0e516872b4b5943d57f6f3f4122f66e65f98a28 100644 (file)
@@ -505,6 +505,8 @@ void mptcp_active_enable(struct sock *sk)
 
                if (dst && dst->dev && (dst->dev->flags & IFF_LOOPBACK))
                        atomic_set(&pernet->active_disable_times, 0);
+
+               dst_release(dst);
        }
 }