s390/qeth: issue STARTLAN as first IPA command

STARTLAN needs to be the first IPA command after MPC initialization
completes.
So move the qeth_send_startlan() call from the layer disciplines
into the core path, right after the MPC handshake.
While at it, replace the magic LAN OFFLINE return code
with the existing enum.

Signed-off-by: Julian Wiedmann <jwi@linux.vnet.ibm.com>
Reviewed-by: Thomas Richter <tmricht@linux.vnet.ibm.com>
Reviewed-by: Ursula Braun <ubraun@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/s390/net/qeth_core.h b/drivers/s390/net/qeth_core.h
index 774ae51569cbef17919e10b0f6cf9d430d3b24a4..e7addea8741b799066644052cba4e9a99f3a3335 100644 (file)
--- a/drivers/s390/net/qeth_core.h
+++ b/drivers/s390/net/qeth_core.h
@@ -913,7 +913,6 @@ void qeth_clear_thread_running_bit(struct qeth_card *, unsigned long);
 int qeth_core_hardsetup_card(struct qeth_card *);
 void qeth_print_status_message(struct qeth_card *);
 int qeth_init_qdio_queues(struct qeth_card *);
-int qeth_send_startlan(struct qeth_card *);
 int qeth_send_ipa_cmd(struct qeth_card *, struct qeth_cmd_buffer *,
                  int (*reply_cb)
                  (struct qeth_card *, struct qeth_reply *, unsigned long),

diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c
index ca8309ff3ad4e03146dded6ad9327da95bea5f52..315d8a2db7c066a0b8eb3739021edc9fde698c19 100644 (file)
--- a/drivers/s390/net/qeth_core_main.c
+++ b/drivers/s390/net/qeth_core_main.c
@@ -2944,7 +2944,7 @@ int qeth_send_ipa_cmd(struct qeth_card *card, struct qeth_cmd_buffer *iob,
 }
 EXPORT_SYMBOL_GPL(qeth_send_ipa_cmd);
 
-int qeth_send_startlan(struct qeth_card *card)
+static int qeth_send_startlan(struct qeth_card *card)
 {
        int rc;
        struct qeth_cmd_buffer *iob;
@@ -2957,7 +2957,6 @@ int qeth_send_startlan(struct qeth_card *card)
        rc = qeth_send_ipa_cmd(card, iob, NULL, NULL);
        return rc;
 }
-EXPORT_SYMBOL_GPL(qeth_send_startlan);
 
 static int qeth_default_setadapterparms_cb(struct qeth_card *card,
                struct qeth_reply *reply, unsigned long data)
@@ -5087,6 +5086,20 @@ retriable:
                goto out;
        }
 
+       rc = qeth_send_startlan(card);
+       if (rc) {
+               QETH_DBF_TEXT_(SETUP, 2, "6err%d", rc);
+               if (rc == IPA_RC_LAN_OFFLINE) {
+                       dev_warn(&card->gdev->dev,
+                               "The LAN is offline\n");
+                       card->lan_online = 0;
+               } else {
+                       rc = -ENODEV;
+                       goto out;
+               }
+       } else
+               card->lan_online = 1;
+
        card->options.ipa4.supported_funcs = 0;
        card->options.ipa6.supported_funcs = 0;
        card->options.adp.supported_funcs = 0;
@@ -5098,14 +5111,14 @@ retriable:
        if (qeth_is_supported(card, IPA_SETADAPTERPARMS)) {
                rc = qeth_query_setadapterparms(card);
                if (rc < 0) {
-                       QETH_DBF_TEXT_(SETUP, 2, "6err%d", rc);
+                       QETH_DBF_TEXT_(SETUP, 2, "7err%d", rc);
                        goto out;
                }
        }
        if (qeth_adp_supported(card, IPA_SETADP_SET_DIAG_ASSIST)) {
                rc = qeth_query_setdiagass(card);
                if (rc < 0) {
-                       QETH_DBF_TEXT_(SETUP, 2, "7err%d", rc);
+                       QETH_DBF_TEXT_(SETUP, 2, "8err%d", rc);
                        goto out;
                }
        }

diff --git a/drivers/s390/net/qeth_l2_main.c b/drivers/s390/net/qeth_l2_main.c
index c298759c30a8b38c650400d1f205580f6a60f35d..bea483307618996240cb90cc3382950ab8b38354 100644 (file)
--- a/drivers/s390/net/qeth_l2_main.c
+++ b/drivers/s390/net/qeth_l2_main.c
@@ -1177,21 +1177,6 @@ static int __qeth_l2_set_online(struct ccwgroup_device *gdev, int recovery_mode)
        /* softsetup */
        QETH_DBF_TEXT(SETUP, 2, "softsetp");
 
-       rc = qeth_send_startlan(card);
-       if (rc) {
-               QETH_DBF_TEXT_(SETUP, 2, "1err%d", rc);
-               if (rc == 0xe080) {
-                       dev_warn(&card->gdev->dev,
-                               "The LAN is offline\n");
-                       card->lan_online = 0;
-                       goto contin;
-               }
-               rc = -ENODEV;
-               goto out_remove;
-       } else
-               card->lan_online = 1;
-
-contin:
        if ((card->info.type == QETH_CARD_TYPE_OSD) ||
            (card->info.type == QETH_CARD_TYPE_OSX)) {
                rc = qeth_l2_start_ipassists(card);

diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net/qeth_l3_main.c
index ac37d050e765bad4e96a72336c41a9ae18236313..06d0addcc058dcccd4333a8f3edcdd96fccb2de4 100644 (file)
--- a/drivers/s390/net/qeth_l3_main.c
+++ b/drivers/s390/net/qeth_l3_main.c
@@ -3227,21 +3227,6 @@ static int __qeth_l3_set_online(struct ccwgroup_device *gdev, int recovery_mode)
        /* softsetup */
        QETH_DBF_TEXT(SETUP, 2, "softsetp");
 
-       rc = qeth_send_startlan(card);
-       if (rc) {
-               QETH_DBF_TEXT_(SETUP, 2, "1err%d", rc);
-               if (rc == 0xe080) {
-                       dev_warn(&card->gdev->dev,
-                               "The LAN is offline\n");
-                       card->lan_online = 0;
-                       goto contin;
-               }
-               rc = -ENODEV;
-               goto out_remove;
-       } else
-               card->lan_online = 1;
-
-contin:
        rc = qeth_l3_setadapter_parms(card);
        if (rc)
                QETH_DBF_TEXT_(SETUP, 2, "2err%04x", rc);