]> www.infradead.org Git - users/hch/misc.git/commitdiff
Bluetooth: btnxpuart: Add an error message if FW dump trigger fails
authorNeeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
Thu, 3 Apr 2025 15:02:22 +0000 (20:32 +0530)
committerLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
Thu, 10 Apr 2025 17:09:36 +0000 (13:09 -0400)
This prints an error message if the FW Dump trigger command fails. This
scenario is mainly observed in legacy chipsets 8987 and 8997 and also
IW416, where this feature is unavailable due to memory constraints.

Fixes: 998e447f443f ("Bluetooth: btnxpuart: Add support for HCI coredump feature")
Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
drivers/bluetooth/btnxpuart.c

index 2d58b8be2c5fb43c15667e06918585b38eff944d..604ab2bba231c5c883a743e06b51f97f07bebad3 100644 (file)
@@ -1286,7 +1286,9 @@ static void nxp_coredump(struct hci_dev *hdev)
        u8 pcmd = 2;
 
        skb = nxp_drv_send_cmd(hdev, HCI_NXP_TRIGGER_DUMP, 1, &pcmd);
-       if (!IS_ERR(skb))
+       if (IS_ERR(skb))
+               bt_dev_err(hdev, "Failed to trigger FW Dump. (%ld)", PTR_ERR(skb));
+       else
                kfree_skb(skb);
 }