]> www.infradead.org Git - users/hch/block.git/commitdiff
usb: usbtmc: Fix memory leak in usbtmc_ioctl_request
authorGuido Kiener <guido.kiener@rohde-schwarz.com>
Mon, 24 Sep 2018 23:30:29 +0000 (01:30 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 28 Sep 2018 13:12:08 +0000 (15:12 +0200)
Kernel memory is allocated twice in new function
usbtmc_ioctl_request and creates a memory leak.
This fix removes the superfluous kmalloc().

Signed-off-by: Guido Kiener <guido.kiener@rohde-schwarz.com>
Fixes: 658f24f4523e ("usb: usbtmc: Add ioctl for generic requests on control")
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/class/usbtmc.c

index 0fcb81a1399b463c3d6c7a189a792d3dedd8d058..dfbcf418dad75ed975fec66855cf7fb6f70b925e 100644 (file)
@@ -1895,10 +1895,6 @@ static int usbtmc_ioctl_request(struct usbtmc_device_data *data,
        if (res)
                return -EFAULT;
 
-       buffer = kmalloc(request.req.wLength, GFP_KERNEL);
-       if (!buffer)
-               return -ENOMEM;
-
        if (request.req.wLength > USBTMC_BUFSIZE)
                return -EMSGSIZE;