]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
accel/qaic: Register for PCI driver at the beginning of module init
authorPranjal Ramajor Asha Kanojiya <quic_pkanojiy@quicinc.com>
Fri, 1 Sep 2023 16:10:37 +0000 (10:10 -0600)
committerJeffrey Hugo <quic_jhugo@quicinc.com>
Fri, 15 Sep 2023 15:29:25 +0000 (09:29 -0600)
As qaic drivers base device is connected to host via PCI framework, it
makes sense to register in PCI framework at the beginning of module
init.

Signed-off-by: Pranjal Ramajor Asha Kanojiya <quic_pkanojiy@quicinc.com>
Reviewed-by: Carl Vanderlip <quic_carlv@quicinc.com>
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Signed-off-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230901161037.6124-1-quic_jhugo@quicinc.com
drivers/accel/qaic/qaic_drv.c

index b5de82e6eb4d56a41b1acabe03a95413522ba3d3..49b5039f4cadceae53574940036be4978f4e9ed9 100644 (file)
@@ -591,22 +591,22 @@ static int __init qaic_init(void)
 {
        int ret;
 
-       ret = mhi_driver_register(&qaic_mhi_driver);
+       ret = pci_register_driver(&qaic_pci_driver);
        if (ret) {
-               pr_debug("qaic: mhi_driver_register failed %d\n", ret);
+               pr_debug("qaic: pci_register_driver failed %d\n", ret);
                return ret;
        }
 
-       ret = pci_register_driver(&qaic_pci_driver);
+       ret = mhi_driver_register(&qaic_mhi_driver);
        if (ret) {
-               pr_debug("qaic: pci_register_driver failed %d\n", ret);
-               goto free_mhi;
+               pr_debug("qaic: mhi_driver_register failed %d\n", ret);
+               goto free_pci;
        }
 
        return 0;
 
-free_mhi:
-       mhi_driver_unregister(&qaic_mhi_driver);
+free_pci:
+       pci_unregister_driver(&qaic_pci_driver);
        return ret;
 }
 
@@ -628,8 +628,8 @@ static void __exit qaic_exit(void)
         * reinitializing the link_up state after the cleanup is done.
         */
        link_up = true;
-       pci_unregister_driver(&qaic_pci_driver);
        mhi_driver_unregister(&qaic_mhi_driver);
+       pci_unregister_driver(&qaic_pci_driver);
 }
 
 module_init(qaic_init);