btrfs: handle root deletion lookup error in btrfs_del_root()

We're deleting a root and looking it up by key does not succeed, this
is an inconsistent state and we can't do anything. All callers handle
errors and abort a transaction.

Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: David Sterba <dsterba@suse.com>

diff --git a/fs/btrfs/root-tree.c b/fs/btrfs/root-tree.c
index 3f6d10eb1aafca9054d175f69e123f0dd06d0b76..ce831660550bfd117c27ca6a4cf8f6a0695b6728 100644 (file)
--- a/fs/btrfs/root-tree.c
+++ b/fs/btrfs/root-tree.c
@@ -322,8 +322,11 @@ int btrfs_del_root(struct btrfs_trans_handle *trans,
        ret = btrfs_search_slot(trans, root, key, path, -1, 1);
        if (ret < 0)
                goto out;
-
-       BUG_ON(ret != 0);
+       if (ret != 0) {
+               /* The root must exist but we did not find it by the key. */
+               ret = -EUCLEAN;
+               goto out;
+       }
 
        ret = btrfs_del_item(trans, root, path);
 out: