]> www.infradead.org Git - users/hch/misc.git/commitdiff
net: stmmac: sun8i: convert to use phy_interface
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Wed, 17 Sep 2025 15:12:37 +0000 (16:12 +0100)
committerJakub Kicinski <kuba@kernel.org>
Sat, 20 Sep 2025 00:19:45 +0000 (17:19 -0700)
dwmac-sun8i supports MII, RMII and RGMII interface modes only. It
is unclear whether the dwmac core interface is different from the
one presented to the outside world.

However, as none of the DTS files set "mac-mode", mac_interface will
be identical to phy_interface.

Convert dwmac-sun8i to use phy_interface when determining the
interface mode rather than mac_interface.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Link: https://patch.msgid.link/E1uytpl-00000006H2k-08pH@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c

index 690f3650f84ed1266fce5cb8aa1c09e4e9100ba0..5d871b2cd111c26d367ea7cc22728f07ec60f60c 100644 (file)
@@ -974,7 +974,7 @@ static int sun8i_dwmac_set_syscon(struct device *dev,
                }
        }
 
-       switch (plat->mac_interface) {
+       switch (plat->phy_interface) {
        case PHY_INTERFACE_MODE_MII:
                /* default */
                break;
@@ -989,7 +989,7 @@ static int sun8i_dwmac_set_syscon(struct device *dev,
                break;
        default:
                dev_err(dev, "Unsupported interface mode: %s",
-                       phy_modes(plat->mac_interface));
+                       phy_modes(plat->phy_interface));
                return -EINVAL;
        }