rtc: rv3028: constify rv3028_rtc_ops

Use RTC_FEATURE_ALARM to signal to the core whether alarms are available
instead of changing the global struct rtc_class_ops, allowing to make it
const.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20210110231752.1418816-14-alexandre.belloni@bootlin.com

diff --git a/drivers/rtc/rtc-rv3028.c b/drivers/rtc/rtc-rv3028.c
index 979407a51c7a9c81f003d5be3b2519611541d5ce..2004f8c5397f7c3a7d5f5b7e9adfc4ff57240a65 100644 (file)
--- a/drivers/rtc/rtc-rv3028.c
+++ b/drivers/rtc/rtc-rv3028.c
@@ -770,9 +770,12 @@ static int rv3028_clkout_register_clk(struct rv3028_data *rv3028,
 }
 #endif
 
-static struct rtc_class_ops rv3028_rtc_ops = {
+static const struct rtc_class_ops rv3028_rtc_ops = {
        .read_time = rv3028_get_time,
        .set_time = rv3028_set_time,
+       .read_alarm = rv3028_get_alarm,
+       .set_alarm = rv3028_set_alarm,
+       .alarm_irq_enable = rv3028_alarm_irq_enable,
        .read_offset = rv3028_read_offset,
        .set_offset = rv3028_set_offset,
        .ioctl = rv3028_ioctl,
@@ -841,12 +844,10 @@ static int rv3028_probe(struct i2c_client *client)
                if (ret) {
                        dev_warn(&client->dev, "unable to request IRQ, alarms disabled\n");
                        client->irq = 0;
-               } else {
-                       rv3028_rtc_ops.read_alarm = rv3028_get_alarm;
-                       rv3028_rtc_ops.set_alarm = rv3028_set_alarm;
-                       rv3028_rtc_ops.alarm_irq_enable = rv3028_alarm_irq_enable;
                }
        }
+       if (!client->irq)
+               clear_bit(RTC_FEATURE_ALARM, rv3028->rtc->features);
 
        ret = regmap_update_bits(rv3028->regmap, RV3028_CTRL1,
                                 RV3028_CTRL1_WADA, RV3028_CTRL1_WADA);