]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
drm/bridge: nxp-ptn3460: Remove a redundant check on existence of bridge->encoder
authorSui Jingfeng <sui.jingfeng@linux.dev>
Mon, 13 May 2024 15:31:00 +0000 (23:31 +0800)
committerRobert Foss <rfoss@kernel.org>
Mon, 13 May 2024 16:31:01 +0000 (18:31 +0200)
Because the existence of 'bridge->encoder' has already been checked before
the ptn3460_bridge_attach() function get called, and drm_bridge_attach()
will quit with a negative error code returned if it fails for some reasons.
Hence, it is guaranteed that the .encoder member of the drm_bridge instance
is not NULL when the ptn3460_bridge_attach() function get called.

Remove the redundant checking codes "if (!bridge->encoder) { ... }".

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Sui Jingfeng <sui.jingfeng@linux.dev>
Signed-off-by: Robert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240513153109.46786-4-sui.jingfeng@linux.dev
drivers/gpu/drm/bridge/nxp-ptn3460.c

index ed93fd4c326572621e670408befb022da8cc9257..e77aab965fcf91f3e8449ff1302f6594d412f5d6 100644 (file)
@@ -229,11 +229,6 @@ static int ptn3460_bridge_attach(struct drm_bridge *bridge,
        if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)
                return 0;
 
-       if (!bridge->encoder) {
-               DRM_ERROR("Parent encoder object not found");
-               return -ENODEV;
-       }
-
        ptn_bridge->connector.polled = DRM_CONNECTOR_POLL_HPD;
        ret = drm_connector_init(bridge->dev, &ptn_bridge->connector,
                        &ptn3460_connector_funcs, DRM_MODE_CONNECTOR_LVDS);