]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
staging: vchiq_dev: Drop userdata local pointer
authorUmang Jain <umang.jain@ideasonboard.com>
Thu, 17 Oct 2024 13:36:29 +0000 (19:06 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 19 Oct 2024 08:04:06 +0000 (10:04 +0200)
The 'userdata' local pointer can be dropped which is set to bulk_waiter.
We can directly pass the waiter->bulk_waiter pointer to
vchiq_bulk_xfer_waiting().

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Link: https://lore.kernel.org/r/20241017133629.216672-7-umang.jain@ideasonboard.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c

index f56057e17963ae8af833a987aeb4af9938183bef..6a9685d9fafc84b52431086282b6789c86b9a1a4 100644 (file)
@@ -289,7 +289,6 @@ static int vchiq_irq_queue_bulk_tx_rx(struct vchiq_instance *instance,
        struct vchiq_service *service;
        struct bulk_waiter_node *waiter = NULL, *iter;
        struct vchiq_bulk bulk_params = {};
-       void *userdata;
        int status = 0;
        int ret;
 
@@ -331,9 +330,9 @@ static int vchiq_irq_queue_bulk_tx_rx(struct vchiq_instance *instance,
                }
                dev_dbg(service->state->dev, "arm: found bulk_waiter %pK for pid %d\n",
                        waiter, current->pid);
-               userdata = &waiter->bulk_waiter;
 
-               status = vchiq_bulk_xfer_waiting(instance, args->handle, userdata);
+               status = vchiq_bulk_xfer_waiting(instance, args->handle,
+                                                &waiter->bulk_waiter);
        } else {
                bulk_params.uoffset = args->data;
                bulk_params.mode = args->mode;