rtlwifi: 8192de: Fix used uninitialized variables in power tracking

ofdm_index_old[] is the index of ofdmswing_table[], and used to indicate
initial value of ROFDM0_X{A,B}TXIQIMBALANCE in rtl8192de_phy_reg_2tarray[]
table, and the initial value is corresponding to calibration thermal value
written in efuse, namely rtlefuse->eeprom_thermalmeter. Then, local
variable ofdm_index_old[] save to rtlpriv->dm.ofdm_index[] for operational
use.

If thermal value (temperature) is increasing, output TX power is lower.
So, we calculate the delta between current and calibration thermal value,
then add power to yield expected and the same output TX power.

Thus, ofdm_index[] should be initialized as rtlpriv->dm.ofdm_index[], and
shift to proper index depends on delta of thermal value. Then, new power
value ofdmswing_table[ofdm_index[]] is written to register.

Reported-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/dm.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/dm.c
index cc9f01a198455dc94aae795e6d970816e6ed0a48..df02cb6e5e91891f87cb171a2d906b737b4c1ca8 100644 (file)
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/dm.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/dm.c
@@ -787,9 +787,9 @@ static void rtl92d_dm_txpower_tracking_callback_thermalmeter(
        bool internal_pa = false;
        long ele_a = 0, ele_d, temp_cck, val_x, value32;
        long val_y, ele_c = 0;
-       u8 ofdm_index[3];
+       u8 ofdm_index[2];
        s8 cck_index = 0;
-       u8 ofdm_index_old[3] = {0, 0, 0};
+       u8 ofdm_index_old[2] = {0, 0};
        s8 cck_index_old = 0;
        u8 index;
        int i;
@@ -846,6 +846,9 @@ static void rtl92d_dm_txpower_tracking_callback_thermalmeter(
        else
                rf = 1;
 
+       if (rtlpriv->dm.thermalvalue && !rtlhal->reloadtxpowerindex)
+               goto old_index_done;
+
        ele_d = rtl_get_bbreg(hw, ROFDM0_XATXIQIMBALANCE,  MASKDWORD) & MASKOFDM_D;
        for (i = 0; i < OFDM_TABLE_SIZE_92D; i++) {
                if (ele_d == (ofdmswing_table[i] & MASKOFDM_D)) {
@@ -897,6 +900,10 @@ static void rtl92d_dm_txpower_tracking_callback_thermalmeter(
                RT_TRACE(rtlpriv, COMP_POWER_TRACKING, DBG_LOUD,
                         "reload ofdm index for band switch\n");
        }
+old_index_done:
+       for (i = 0; i < rf; i++)
+               ofdm_index[i] = rtlpriv->dm.ofdm_index[i];
+
        rtlpriv->dm.thermalvalue_avg
                    [rtlpriv->dm.thermalvalue_avg_index] = thermalvalue;
        rtlpriv->dm.thermalvalue_avg_index++;