net/mlx5e: Add hairpin debugfs files

We refer to a TC NIC rule that involves forwarding as "hairpin".
Hairpin queues are mlx5 hardware specific implementation for hardware
forwarding of such packets.

For debug purposes, introduce debugfs files which:
* Expose the number of active hairpins
* Dump the hairpin table
* Allow control over the number and size of the hairpin queues instead
  of the hard-coded values.

This allows us to get visibility of the feature in order to improve it
for next generation hardware.

Add debugfs files:
  fs/tc/hairpin_num_active
  fs/tc/hairpin_num_queues
  fs/tc/hairpin_queue_size
  fs/tc/hairpin_table_dump

Note that the new values will only take effect on the next queues
creation, it does not affect existing queues.

Signed-off-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
index 800442eaf9b490c58ec5d31c5b09b89399cb1ee5..99a7edb8866109d0bf4297ef3f4db3315d13622a 100644 (file)
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
@@ -100,6 +100,7 @@ struct mlx5e_tc_table {
        struct mlx5_tc_ct_priv         *ct;
        struct mapping_ctx             *mapping;
        struct mlx5e_hairpin_params    hairpin_params;
+       struct dentry                  *dfs_root;
 };
 
 struct mlx5e_tc_attr_to_reg_mapping mlx5e_tc_attr_to_reg_mappings[] = {
@@ -1023,6 +1024,118 @@ static int mlx5e_hairpin_get_prio(struct mlx5e_priv *priv,
        return 0;
 }
 
+static int debugfs_hairpin_queues_set(void *data, u64 val)
+{
+       struct mlx5e_hairpin_params *hp = data;
+
+       if (!val) {
+               mlx5_core_err(hp->mdev,
+                             "Number of hairpin queues must be > 0\n");
+               return -EINVAL;
+       }
+
+       hp->num_queues = val;
+
+       return 0;
+}
+
+static int debugfs_hairpin_queues_get(void *data, u64 *val)
+{
+       struct mlx5e_hairpin_params *hp = data;
+
+       *val = hp->num_queues;
+
+       return 0;
+}
+DEFINE_DEBUGFS_ATTRIBUTE(fops_hairpin_queues, debugfs_hairpin_queues_get,
+                        debugfs_hairpin_queues_set, "%llu\n");
+
+static int debugfs_hairpin_queue_size_set(void *data, u64 val)
+{
+       struct mlx5e_hairpin_params *hp = data;
+
+       if (val > BIT(MLX5_CAP_GEN(hp->mdev, log_max_hairpin_num_packets))) {
+               mlx5_core_err(hp->mdev,
+                             "Invalid hairpin queue size, must be <= %lu\n",
+                             BIT(MLX5_CAP_GEN(hp->mdev,
+                                              log_max_hairpin_num_packets)));
+               return -EINVAL;
+       }
+
+       hp->queue_size = roundup_pow_of_two(val);
+
+       return 0;
+}
+
+static int debugfs_hairpin_queue_size_get(void *data, u64 *val)
+{
+       struct mlx5e_hairpin_params *hp = data;
+
+       *val = hp->queue_size;
+
+       return 0;
+}
+DEFINE_DEBUGFS_ATTRIBUTE(fops_hairpin_queue_size,
+                        debugfs_hairpin_queue_size_get,
+                        debugfs_hairpin_queue_size_set, "%llu\n");
+
+static int debugfs_hairpin_num_active_get(void *data, u64 *val)
+{
+       struct mlx5e_tc_table *tc = data;
+       struct mlx5e_hairpin_entry *hpe;
+       u32 cnt = 0;
+       u32 bkt;
+
+       mutex_lock(&tc->hairpin_tbl_lock);
+       hash_for_each(tc->hairpin_tbl, bkt, hpe, hairpin_hlist)
+               cnt++;
+       mutex_unlock(&tc->hairpin_tbl_lock);
+
+       *val = cnt;
+
+       return 0;
+}
+DEFINE_DEBUGFS_ATTRIBUTE(fops_hairpin_num_active,
+                        debugfs_hairpin_num_active_get, NULL, "%llu\n");
+
+static int debugfs_hairpin_table_dump_show(struct seq_file *file, void *priv)
+
+{
+       struct mlx5e_tc_table *tc = file->private;
+       struct mlx5e_hairpin_entry *hpe;
+       u32 bkt;
+
+       mutex_lock(&tc->hairpin_tbl_lock);
+       hash_for_each(tc->hairpin_tbl, bkt, hpe, hairpin_hlist)
+               seq_printf(file, "Hairpin peer_vhca_id %u prio %u refcnt %u\n",
+                          hpe->peer_vhca_id, hpe->prio,
+                          refcount_read(&hpe->refcnt));
+       mutex_unlock(&tc->hairpin_tbl_lock);
+
+       return 0;
+}
+DEFINE_SHOW_ATTRIBUTE(debugfs_hairpin_table_dump);
+
+static void mlx5e_tc_debugfs_init(struct mlx5e_tc_table *tc,
+                                 struct dentry *dfs_root)
+{
+       if (IS_ERR_OR_NULL(dfs_root))
+               return;
+
+       tc->dfs_root = debugfs_create_dir("tc", dfs_root);
+       if (!tc->dfs_root)
+               return;
+
+       debugfs_create_file("hairpin_num_queues", 0644, tc->dfs_root,
+                           &tc->hairpin_params, &fops_hairpin_queues);
+       debugfs_create_file("hairpin_queue_size", 0644, tc->dfs_root,
+                           &tc->hairpin_params, &fops_hairpin_queue_size);
+       debugfs_create_file("hairpin_num_active", 0444, tc->dfs_root, tc,
+                           &fops_hairpin_num_active);
+       debugfs_create_file("hairpin_table_dump", 0444, tc->dfs_root, tc,
+                           &debugfs_hairpin_table_dump_fops);
+}
+
 static void
 mlx5e_hairpin_params_init(struct mlx5e_hairpin_params *hairpin_params,
                          struct mlx5_core_dev *mdev)
@@ -5249,6 +5362,8 @@ int mlx5e_tc_nic_init(struct mlx5e_priv *priv)
                goto err_reg;
        }
 
+       mlx5e_tc_debugfs_init(tc, mlx5e_fs_get_debugfs_root(priv->fs));
+
        return 0;
 
 err_reg:
@@ -5277,6 +5392,8 @@ void mlx5e_tc_nic_cleanup(struct mlx5e_priv *priv)
 {
        struct mlx5e_tc_table *tc = mlx5e_fs_get_tc(priv->fs);
 
+       debugfs_remove_recursive(tc->dfs_root);
+
        if (tc->netdevice_nb.notifier_call)
                unregister_netdevice_notifier_dev_net(priv->netdev,
                                                      &tc->netdevice_nb,