media: sti/hva: add missing clk_disable_unprepare()

Fixes this smatch warning:

drivers/media/platform/sti/hva/hva-hw.c:453 hva_hw_runtime_resume() warn: 'hva->clk' not released on lines: 450.

Call clk_disable_unprepare() when clk_set_rate() fails.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: Jean-Christophe Trotin <jean-christophe.trotin@st.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

diff --git a/drivers/media/platform/sti/hva/hva-hw.c b/drivers/media/platform/sti/hva/hva-hw.c
index 43f279e2a6a380cf8e077a8f661d85943200a7aa..f59811e27f51fc345bea75663bdb1fb2013479ff 100644 (file)
--- a/drivers/media/platform/sti/hva/hva-hw.c
+++ b/drivers/media/platform/sti/hva/hva-hw.c
@@ -447,6 +447,7 @@ int hva_hw_runtime_resume(struct device *dev)
        if (clk_set_rate(hva->clk, CLK_RATE)) {
                dev_err(dev, "%s     failed to set clock frequency\n",
                        HVA_PREFIX);
+               clk_disable_unprepare(hva->clk);
                return -EINVAL;
        }