Include qapi/qmp/qerror.h exactly where needed

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20180211093607.27351-2-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>

diff --git a/block.c b/block.c
index 814e5a02da692a6b13b956d84897851537447903..628910f6382f785a435783a827bad47e2b37d41a 100644 (file)
--- a/block.c
+++ b/block.c
@@ -32,7 +32,6 @@
 #include "qemu/module.h"
 #include "qapi/error.h"
 #include "qapi/qmp/qdict.h"
-#include "qapi/qmp/qerror.h"
 #include "qapi/qmp/qjson.h"
 #include "qapi/qmp/qstring.h"
 #include "sysemu/block-backend.h"

diff --git a/block/qcow2.c b/block/qcow2.c
index 57a517e2bdd8472bf2e7217bcc9ca8f08377c546..fd79c0ebaaf2ec9ea918876f13ea75265df3977f 100644 (file)
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -30,7 +30,6 @@
 #include "block/qcow2.h"
 #include "qemu/error-report.h"
 #include "qapi/error.h"
-#include "qapi/qmp/qerror.h"
 #include "qapi/qmp/qdict.h"
 #include "qapi/qmp/qstring.h"
 #include "qapi-event.h"

diff --git a/chardev/char-fe.c b/chardev/char-fe.c
index c611b3fa3e0f432a3bb719a3af30403a437f73f0..e5f870e4d21aff10542e3f9230d9e5a02e4bc843 100644 (file)
--- a/chardev/char-fe.c
+++ b/chardev/char-fe.c
@@ -24,6 +24,7 @@
 #include "qemu/osdep.h"
 #include "qemu/error-report.h"
 #include "qapi/error.h"
+#include "qapi/qmp/qerror.h"
 #include "qapi-visit.h"
 #include "sysemu/replay.h"
 

diff --git a/chardev/char.c b/chardev/char.c
index 01d979a1da5e5605ebad000ccad4b10cbf937522..c9a4da55163194370772d0d9a3aa81df5707cb28 100644 (file)
--- a/chardev/char.c
+++ b/chardev/char.c
@@ -32,6 +32,7 @@
 #include "qmp-commands.h"
 #include "qapi-visit.h"
 #include "qapi/error.h"
+#include "qapi/qmp/qerror.h"
 #include "sysemu/replay.h"
 #include "qemu/help_option.h"
 #include "qemu/option.h"

diff --git a/qom/object_interfaces.c b/qom/object_interfaces.c
index 80d09139be0e753481c8635a61946c412e18915c..43d9aa0946d442b47f2d9959d4f7a48c66fb53be 100644 (file)
--- a/qom/object_interfaces.c
+++ b/qom/object_interfaces.c
@@ -1,6 +1,7 @@
 #include "qemu/osdep.h"
 #include "qapi/error.h"
 #include "qapi/qmp/qdict.h"
+#include "qapi/qmp/qerror.h"
 #include "qom/object_interfaces.h"
 #include "qemu/module.h"
 #include "qemu/option.h"

diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py
index 7e1cfc13f084a0670ccf0d23fbf4e4812f1e85b9..bc2b8b581a002ea93c4541c95deab6c76ca8587d 100644 (file)
--- a/scripts/qapi-visit.py
+++ b/scripts/qapi-visit.py
@@ -371,13 +371,13 @@ fdef.write(mcgen('''
 #include "qemu/osdep.h"
 #include "qemu-common.h"
 #include "qapi/error.h"
+#include "qapi/qmp/qerror.h"
 #include "%(prefix)sqapi-visit.h"
 ''',
                  prefix=prefix))
 
 fdecl.write(mcgen('''
 #include "qapi/visitor.h"
-#include "qapi/qmp/qerror.h"
 #include "%(prefix)sqapi-types.h"
 
 ''',