net: ethtool: fix the error condition in ethtool_get_phy_stats_ethtool()

Clang static checker (scan-build) warning:
net/ethtool/ioctl.c:line 2233, column 2
Called function pointer is null (null dereference).

Return '-EOPNOTSUPP' when 'ops->get_ethtool_phy_stats' is NULL to fix
this typo error.

Fixes: 201ed315f967 ("net/ethtool/ioctl: split ethtool_get_phy_stats into multiple helpers")
Signed-off-by: Su Hui <suhui@nfschina.com>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Reviewed-by: Hariprasad Kelam <hkelam@marvell.com>
Link: https://lore.kernel.org/r/20240605034742.921751-1-suhui@nfschina.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

diff --git a/net/ethtool/ioctl.c b/net/ethtool/ioctl.c
index 5a55270aa86e8804f467bd094f8bca9171bc2617..e645d751a5e8998064ef5fa239d465f66c044e6f 100644 (file)
--- a/net/ethtool/ioctl.c
+++ b/net/ethtool/ioctl.c
@@ -2220,7 +2220,7 @@ static int ethtool_get_phy_stats_ethtool(struct net_device *dev,
        const struct ethtool_ops *ops = dev->ethtool_ops;
        int n_stats, ret;
 
-       if (!ops || !ops->get_sset_count || ops->get_ethtool_phy_stats)
+       if (!ops || !ops->get_sset_count || !ops->get_ethtool_phy_stats)
                return -EOPNOTSUPP;
 
        n_stats = ops->get_sset_count(dev, ETH_SS_PHY_STATS);