]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
drm/amd/display: Fix __umoddi3 undefined for 32 bit compilation
authorRodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Thu, 30 Jun 2022 18:46:18 +0000 (14:46 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 30 Jun 2022 23:34:36 +0000 (19:34 -0400)
While we tried to build amdgpu on i386, we got this error:

ERROR: modpost: "__umoddi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!

This commit fixes this issue by replacing the standard module operator
with div_u64_rem.

Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Randy Dunlap <rdunlap@infradead.org>
Fixes: d3dfceb58de5 ("drm/amd/display: Add dependant changes for DCN32/321")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c

index a10ec5919194166ba083ddcf05606643e3fd51ad..790aa2b3952ccc753ef7332002c7f2a6e6e86136 100644 (file)
@@ -208,12 +208,14 @@ static uint32_t dcn32_cache_lines_for_surface(struct dc *dc, uint32_t surface_si
        uint32_t num_cached_bytes = 0;
        uint32_t remaining_size = 0;
        uint32_t cache_line_size = dc->caps.cache_line_size;
+       uint32_t remainder = 0;
 
        /* 1. Calculate surface size minus the number of bytes stored
         * in the first cache line (all bytes in first cache line might
         * not be fully used).
         */
-       num_cached_bytes = cache_line_size - (start_address % cache_line_size);
+       div_u64_rem(start_address, cache_line_size, &remainder);
+       num_cached_bytes = cache_line_size - remainder;
        remaining_size = surface_size - num_cached_bytes;
 
        /* 2. Calculate number of cache lines that will be fully used with