speakup: i18n: Switch to kmemdup_nul() in spk_msg_set()

Use kmemdup_nul() helper instead of open-coding to
simplify the code in spk_msg_set().

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20210406034434.442251-1-yangyingliang@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/accessibility/speakup/i18n.c b/drivers/accessibility/speakup/i18n.c
index ee240d36f947c997afd84ca585ecd07a8ad91f71..46bd50f3c3a42c119e1523cb7f1f6cb64fb8cbe6 100644 (file)
--- a/drivers/accessibility/speakup/i18n.c
+++ b/drivers/accessibility/speakup/i18n.c
@@ -548,12 +548,10 @@ ssize_t spk_msg_set(enum msg_index_t index, char *text, size_t length)
        if ((index < MSG_FIRST_INDEX) || (index >= MSG_LAST_INDEX))
                return -EINVAL;
 
-       newstr = kmalloc(length + 1, GFP_KERNEL);
+       newstr = kmemdup_nul(text, length, GFP_KERNEL);
        if (!newstr)
                return -ENOMEM;
 
-       memcpy(newstr, text, length);
-       newstr[length] = '\0';
        if (index >= MSG_FORMATTED_START &&
            index <= MSG_FORMATTED_END &&
            !fmt_validate(speakup_default_msgs[index], newstr)) {