debugfs: remove return value of debugfs_create_devm_seqfile()

No one checks the return value of debugfs_create_devm_seqfile(), as it's
not needed, so make the return value void, so that no one tries to do so
in the future.

Link: https://lore.kernel.org/r/20201023131037.2500765-1-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/Documentation/filesystems/debugfs.rst b/Documentation/filesystems/debugfs.rst
index 728ab57a611a468db44f95a1af01d45629ac944d..0f2292e367e62bdf638b9c812b7df38ce1bbb7ff 100644 (file)
--- a/Documentation/filesystems/debugfs.rst
+++ b/Documentation/filesystems/debugfs.rst
@@ -199,7 +199,7 @@ of its elements. Note: Once array is created its size can not be changed.
 
 There is a helper function to create device related seq_file::
 
-   struct dentry *debugfs_create_devm_seqfile(struct device *dev,
+   void debugfs_create_devm_seqfile(struct device *dev,
                                const char *name,
                                struct dentry *parent,
                                int (*read_fn)(struct seq_file *s,

diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c
index a768a09430c3a9c0cad71e2f47a8544acafdf9c0..686e0ad287880c15406a479a3acc209a8fa1396f 100644 (file)
--- a/fs/debugfs/file.c
+++ b/fs/debugfs/file.c
@@ -1127,24 +1127,23 @@ static const struct file_operations debugfs_devm_entry_ops = {
  *     file will be created in the root of the debugfs filesystem.
  * @read_fn: function pointer called to print the seq_file content.
  */
-struct dentry *debugfs_create_devm_seqfile(struct device *dev, const char *name,
-                                          struct dentry *parent,
-                                          int (*read_fn)(struct seq_file *s,
-                                                         void *data))
+void debugfs_create_devm_seqfile(struct device *dev, const char *name,
+                                struct dentry *parent,
+                                int (*read_fn)(struct seq_file *s, void *data))
 {
        struct debugfs_devm_entry *entry;
 
        if (IS_ERR(parent))
-               return ERR_PTR(-ENOENT);
+               return;
 
        entry = devm_kzalloc(dev, sizeof(*entry), GFP_KERNEL);
        if (!entry)
-               return ERR_PTR(-ENOMEM);
+               return;
 
        entry->read = read_fn;
        entry->dev = dev;
 
-       return debugfs_create_file(name, S_IRUGO, parent, entry,
-                                  &debugfs_devm_entry_ops);
+       debugfs_create_file(name, S_IRUGO, parent, entry,
+                           &debugfs_devm_entry_ops);
 }
 EXPORT_SYMBOL_GPL(debugfs_create_devm_seqfile);

diff --git a/include/linux/debugfs.h b/include/linux/debugfs.h
index 851dd1f9a8a5f5466933e23709c50d7c39e13d5b..d6c4cc9ecc77cca2f6d6e5b719ba4eb576dd2fd1 100644 (file)
--- a/include/linux/debugfs.h
+++ b/include/linux/debugfs.h
@@ -144,10 +144,9 @@ void debugfs_create_u32_array(const char *name, umode_t mode,
                              struct dentry *parent,
                              struct debugfs_u32_array *array);
 
-struct dentry *debugfs_create_devm_seqfile(struct device *dev, const char *name,
-                                          struct dentry *parent,
-                                          int (*read_fn)(struct seq_file *s,
-                                                         void *data));
+void debugfs_create_devm_seqfile(struct device *dev, const char *name,
+                                struct dentry *parent,
+                                int (*read_fn)(struct seq_file *s, void *data));
 
 bool debugfs_initialized(void);
 
@@ -327,13 +326,12 @@ static inline void debugfs_create_u32_array(const char *name, umode_t mode,
 {
 }
 
-static inline struct dentry *debugfs_create_devm_seqfile(struct device *dev,
-                                                        const char *name,
-                                                        struct dentry *parent,
-                                          int (*read_fn)(struct seq_file *s,
-                                                         void *data))
+static inline void debugfs_create_devm_seqfile(struct device *dev,
+                                              const char *name,
+                                              struct dentry *parent,
+                                              int (*read_fn)(struct seq_file *s,
+                                                             void *data))
 {
-       return ERR_PTR(-ENODEV);
 }
 
 static inline ssize_t debugfs_read_file_bool(struct file *file,