be2net: define BE_MAX_MTU

This patch defines a new macro BE_MAX_MTU to make the code in be_change_mtu()
more readable.

Signed-off-by: Kalesh AP <kalesh.purayil@emulex.com>
Signed-off-by: Sathya Perla <sathya.perla@emulex.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/emulex/benet/be.h b/drivers/net/ethernet/emulex/benet/be.h
index 069bdda00c55ce03443813609fd808de34ee0ffe..5ccfce7d616dbf86048a455d3841da8cc1f60ca6 100644 (file)
--- a/drivers/net/ethernet/emulex/benet/be.h
+++ b/drivers/net/ethernet/emulex/benet/be.h
@@ -86,6 +86,8 @@ static inline char *nic_name(struct pci_dev *pdev)
 
 #define BE_MAX_JUMBO_FRAME_SIZE        9018
 #define BE_MIN_MTU             256
+#define BE_MAX_MTU              (BE_MAX_JUMBO_FRAME_SIZE -     \
+                                (ETH_HLEN + ETH_FCS_LEN))
 
 #define BE_NUM_VLANS_SUPPORTED 64
 #define BE_MAX_EQD             128u

diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index 3162a41c3c3a2b8b7412ac42671cca4f2a845f8b..fe007ea4a01c3947919211640c6ebe44dd95f526 100644 (file)
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -1073,15 +1073,15 @@ static netdev_tx_t be_xmit(struct sk_buff *skb, struct net_device *netdev)
 static int be_change_mtu(struct net_device *netdev, int new_mtu)
 {
        struct be_adapter *adapter = netdev_priv(netdev);
-       if (new_mtu < BE_MIN_MTU ||
-           new_mtu > (BE_MAX_JUMBO_FRAME_SIZE - (ETH_HLEN + ETH_FCS_LEN))) {
-               dev_info(&adapter->pdev->dev,
-                        "MTU must be between %d and %d bytes\n",
-                        BE_MIN_MTU,
-                        (BE_MAX_JUMBO_FRAME_SIZE - (ETH_HLEN + ETH_FCS_LEN)));
+       struct device *dev = &adapter->pdev->dev;
+
+       if (new_mtu < BE_MIN_MTU || new_mtu > BE_MAX_MTU) {
+               dev_info(dev, "MTU must be between %d and %d bytes\n",
+                        BE_MIN_MTU, BE_MAX_MTU);
                return -EINVAL;
        }
-       dev_info(&adapter->pdev->dev, "MTU changed from %d to %d bytes\n",
+
+       dev_info(dev, "MTU changed from %d to %d bytes\n",
                 netdev->mtu, new_mtu);
        netdev->mtu = new_mtu;
        return 0;