]> www.infradead.org Git - users/dwmw2/qemu.git/commitdiff
hw/audio/ac97: Use the QOM DEVICE() macro to access DeviceState.qdev
authorPhilippe Mathieu-Daudé <philmd@redhat.com>
Tue, 28 May 2019 16:40:16 +0000 (18:40 +0200)
committerLaurent Vivier <laurent@vivier.eu>
Thu, 6 Jun 2019 09:36:43 +0000 (11:36 +0200)
Rather than looking inside the definition of a DeviceState with
"s->qdev", use the QOM prefered style: "DEVICE(s)".

This patch was generated using the following Coccinelle script
(with a bit of manual fix-up, removing an extra space to please
checkpatch.pl):

    // Use DEVICE() macros to access DeviceState.qdev
    @use_device_macro_to_access_qdev@
    expression obj;
    identifier dev;
    @@
    -&obj->dev.qdev
    +DEVICE(obj)

Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>.
Message-Id: <20190528164020.32250-7-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
hw/audio/ac97.c

index 2265622d44a220140c6297966b26ddeca301ef87..a4e8d99e7775e8cc122a2ddd50b1018b75e96451 100644 (file)
@@ -1388,7 +1388,7 @@ static void ac97_realize(PCIDevice *dev, Error **errp)
     pci_register_bar (&s->dev, 0, PCI_BASE_ADDRESS_SPACE_IO, &s->io_nam);
     pci_register_bar (&s->dev, 1, PCI_BASE_ADDRESS_SPACE_IO, &s->io_nabm);
     AUD_register_card ("ac97", &s->card);
-    ac97_on_reset (&s->dev.qdev);
+    ac97_on_reset(DEVICE(s));
 }
 
 static void ac97_exit(PCIDevice *dev)