uprobes: Avoid false-positive lockdep splat on CONFIG_PREEMPT_RT=y in the ri_timer...

Avoid a false-positive lockdep warning in the CONFIG_PREEMPT_RT=y
configuration when using write_seqcount_begin() in the uprobe timer
callback by using raw_write_* APIs.

Uprobe's use of timer callback is guaranteed to not race with itself
for a given uprobe_task, and as such seqcount's insistence on having
preemption disabled on the writer side is irrelevant. So switch to
raw_ variants of seqcount API instead of disabling preemption unnecessarily.

Also, point out in the comments more explicitly why we use seqcount
despite our reader side being rather simple and never retrying. We favor
well-maintained kernel primitive in favor of open-coding our own memory
barriers.

Fixes: 8622e45b5da1 ("uprobes: Reuse return_instances between multiple uretprobes within task")
Reported-by: Alexei Starovoitov <ast@kernel.org>
Suggested-by: Sebastian Siewior <bigeasy@linutronix.de>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Oleg Nesterov <oleg@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: stable@kernel.org
Link: https://lore.kernel.org/r/20250404194848.2109539-1-andrii@kernel.org

diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
index 615b4e6d22c7b16abf8a2d259ee47b9771e3aa1c..8d783b5882b6a3ea3789d552fb6de8bdea905121 100644 (file)
--- a/kernel/events/uprobes.c
+++ b/kernel/events/uprobes.c
@@ -1956,6 +1956,9 @@ static void free_ret_instance(struct uprobe_task *utask,
         * to-be-reused return instances for future uretprobes. If ri_timer()
         * happens to be running right now, though, we fallback to safety and
         * just perform RCU-delated freeing of ri.
+        * Admittedly, this is a rather simple use of seqcount, but it nicely
+        * abstracts away all the necessary memory barriers, so we use
+        * a well-supported kernel primitive here.
         */
        if (raw_seqcount_try_begin(&utask->ri_seqcount, seq)) {
                /* immediate reuse of ri without RCU GP is OK */
@@ -2016,12 +2019,20 @@ static void ri_timer(struct timer_list *timer)
        /* RCU protects return_instance from freeing. */
        guard(rcu)();
 
-       write_seqcount_begin(&utask->ri_seqcount);
+       /*
+        * See free_ret_instance() for notes on seqcount use.
+        * We also employ raw API variants to avoid lockdep false-positive
+        * warning complaining about enabled preemption. The timer can only be
+        * invoked once for a uprobe_task. Therefore there can only be one
+        * writer. The reader does not require an even sequence count to make
+        * progress, so it is OK to remain preemptible on PREEMPT_RT.
+        */
+       raw_write_seqcount_begin(&utask->ri_seqcount);
 
        for_each_ret_instance_rcu(ri, utask->return_instances)
                hprobe_expire(&ri->hprobe, false);
 
-       write_seqcount_end(&utask->ri_seqcount);
+       raw_write_seqcount_end(&utask->ri_seqcount);
 }
 
 static struct uprobe_task *alloc_utask(void)