]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
ASoC: Intel: avs: Clearly state assumptions of hw_params()
authorCezary Rojewski <cezary.rojewski@intel.com>
Thu, 9 Jan 2025 12:22:11 +0000 (13:22 +0100)
committerMark Brown <broonie@kernel.org>
Thu, 9 Jan 2025 12:14:23 +0000 (12:14 +0000)
There are no NULL-checks for fe/be_hw_params as there is an implicit
assumption that framework opens valid DPCMs only. State that clearly.

Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
Link: https://patch.msgid.link/20250109122216.3667847-9-cezary.rojewski@intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/avs/pcm.c

index 5878cfdbbee50f73d65617562a63b9fb540b50ea..4bfbcb5a5ae8aff5a981389e61afb3c72b07b15c 100644 (file)
@@ -161,6 +161,7 @@ static int avs_dai_be_hw_params(struct snd_pcm_substream *substream,
        struct snd_soc_dpcm *dpcm;
 
        be = snd_soc_substream_to_rtd(substream);
+       /* dpcm_fe_dai_open() guarantees the list is not empty at this point. */
        for_each_dpcm_fe(be, substream->stream, dpcm) {
                fe = dpcm->fe;
                fe_hw_params = &fe->dpcm[substream->stream].hw_params;
@@ -576,6 +577,7 @@ static int avs_dai_fe_hw_params(struct snd_pcm_substream *substream,
        hdac_stream(host_stream)->format_val = 0;
 
        fe = snd_soc_substream_to_rtd(substream);
+       /* dpcm_fe_dai_open() guarantees the list is not empty at this point. */
        for_each_dpcm_be(fe, substream->stream, dpcm) {
                be = dpcm->be;
                be_hw_params = &be->dpcm[substream->stream].hw_params;