]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
drm/amd/display: Fix null pointer dereference in error message
authorCong Liu <liucong2@kylinos.cn>
Tue, 26 Sep 2023 05:56:17 +0000 (13:56 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 28 Sep 2023 19:36:57 +0000 (15:36 -0400)
This patch fixes a null pointer dereference in the error message that is
printed when the Display Core (DC) fails to initialize. The original
message includes the DC version number, which is undefined if the DC is
not initialized.

Fixes: 9788d087caff ("drm/amd/display: improve the message printed when loading DC")
Signed-off-by: Cong Liu <liucong2@kylinos.cn>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

index c53daaddc888a58a0c3872ccfd1ca5f1be4c49ef..62566a26fcd677710065cd30997f7079d334b01d 100644 (file)
@@ -1708,8 +1708,7 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
                DRM_INFO("Display Core v%s initialized on %s\n", DC_VER,
                         dce_version_to_string(adev->dm.dc->ctx->dce_version));
        } else {
-               DRM_INFO("Display Core v%s failed to initialize on %s\n", DC_VER,
-                        dce_version_to_string(adev->dm.dc->ctx->dce_version));
+               DRM_INFO("Display Core failed to initialize with v%s!\n", DC_VER);
                goto error;
        }