]> www.infradead.org Git - users/hch/misc.git/commitdiff
ASoC: SOF: imx: Fix devm_ioremap_resource check
authorDaniel Baluta <daniel.baluta@nxp.com>
Tue, 2 Sep 2025 10:21:00 +0000 (13:21 +0300)
committerMark Brown <broonie@kernel.org>
Tue, 2 Sep 2025 11:51:32 +0000 (12:51 +0100)
devm_ioremap_resource does not return NULL on error
but an error pointer so we need to use IS_ERR to check
the return code.

While at it also pass the error code to dev_err_probe
to improve logging.

Fixes: bc163baef570 ("ASoC: Use of_reserved_mem_region_to_resource() for "memory-region"")
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
Link: https://patch.msgid.link/20250902102101.378809-1-daniel.baluta@nxp.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/imx/imx-common.c

index f00b381cec3b4aa03c76068bac120582fec64d0a..d66c198b861ae9f40cfd064ea2dab362ca3d750c 100644 (file)
@@ -316,9 +316,9 @@ static int imx_parse_ioremap_memory(struct snd_sof_dev *sdev)
                }
 
                sdev->bar[blk_type] = devm_ioremap_resource(sdev->dev, res);
-               if (!sdev->bar[blk_type])
+               if (IS_ERR(sdev->bar[blk_type]))
                        return dev_err_probe(sdev->dev,
-                                            -ENOMEM,
+                                            PTR_ERR(sdev->bar[blk_type]),
                                             "failed to ioremap %s region\n",
                                             chip_info->memory[i].name);
        }