]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
Input: cyttsp - drop the phys path
authorLinus Walleij <linus.walleij@linaro.org>
Sat, 10 Apr 2021 07:32:46 +0000 (00:32 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Sat, 10 Apr 2021 07:46:07 +0000 (00:46 -0700)
When I test to use the CY8CTMA340 with PostmarketOS I don't have any
problem whatsoever in dropping this phys path, it finds and uses the
touchscreen just as well. I suppose it is because userspace is using
modern input libraries.

I challenge the maintainers to point out a valid and still used
userspace that actually need this. I say we drop it.

Reviewed-by: Javier Martinez Canillas <javier@dowhile0.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20210408131153.3446138-7-linus.walleij@linaro.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/touchscreen/cyttsp_core.c
drivers/input/touchscreen/cyttsp_core.h

index 42e353f119764bdf9aed2082831246c2cd82152e..b0477f55fb79b31520fed259456f1188b9883df8 100644 (file)
@@ -640,10 +640,8 @@ struct cyttsp *cyttsp_probe(const struct cyttsp_bus_ops *bus_ops,
                return ERR_PTR(error);
 
        init_completion(&ts->bl_ready);
-       snprintf(ts->phys, sizeof(ts->phys), "%s/input0", dev_name(dev));
 
        input_dev->name = "Cypress TTSP TouchScreen";
-       input_dev->phys = ts->phys;
        input_dev->id.bustype = bus_ops->bustype;
        input_dev->dev.parent = ts->dev;
 
index 8c651336ac1256bcfc297a215ceb3440efc7072f..9bc4fe7e6ac5091a2c1cd2a7c5cb38c94bad82bc 100644 (file)
@@ -114,7 +114,6 @@ struct cyttsp {
        struct device *dev;
        int irq;
        struct input_dev *input;
-       char phys[32];
        const struct cyttsp_bus_ops *bus_ops;
        struct cyttsp_bootloader_data bl_data;
        struct cyttsp_sysinfo_data sysinfo_data;