Fix bad function definition

Warnings by checkpatch.pl.
I have learned something today:
https://eklitzke.org/c-functions-without-arguments

Signed-off-by: Dimitri Papadopoulos <3350651+DimitriPapadopoulos@users.noreply.gitlab.com>

diff --git a/array.c b/array.c
index 1aba7bda37c185c0e6cd932e726220b265d7e67b..01eeb80eb480a09b68b05c5d8bc57f9aac3b6dde 100644 (file)
--- a/array.c
+++ b/array.c
@@ -48,7 +48,7 @@
 
 #include "openconnect-internal.h"
 
-static struct oc_auth_form *plain_auth_form() {
+static struct oc_auth_form *plain_auth_form(void) {
         struct oc_auth_form *form;
         struct oc_form_opt *opt, *opt2, *opt3;
 

diff --git a/compat.c b/compat.c
index f83a520b3a68e779fe150d7146ea297038d79ac5..c0d1a4dc0eae6c8a4e128403fad3f01c8a952794 100644 (file)
--- a/compat.c
+++ b/compat.c
@@ -268,7 +268,7 @@ char *openconnect__win32_strerror(DWORD err)
        return msgutf8;
 }
 
-int openconnect__win32_sock_init()
+int openconnect__win32_sock_init(void)
 {
        WSADATA data;
        if (WSAStartup (MAKEWORD(1, 1), &data) != 0) {

diff --git a/f5.c b/f5.c
index df26d2f8f20889cde2832e87bee64290a987d540..99eb4ee2e89fac1654954f36a21d6de8dd9b83b3 100644 (file)
--- a/f5.c
+++ b/f5.c
@@ -37,7 +37,7 @@
 
 #define XCAST(x) ((const xmlChar *)(x))
 
-static struct oc_auth_form *plain_auth_form() {
+static struct oc_auth_form *plain_auth_form(void) {
        struct oc_auth_form *form;
        struct oc_form_opt *opt, *opt2;
 

diff --git a/gnutls.c b/gnutls.c
index 4cabc6dd7fe7e54121d71500dd1d4681024f9535..b8a55e92b41a3b9fae4ec721dbca5af788212c3d 100644 (file)
--- a/gnutls.c
+++ b/gnutls.c
@@ -67,7 +67,7 @@ static int gnutls_pin_callback(void *priv, int attempt, const char *uri,
 
 static char tls_library_version[32] = "";
 
-const char *openconnect_get_tls_library_version()
+const char *openconnect_get_tls_library_version(void)
 {
        if (!*tls_library_version) {
                snprintf(tls_library_version, sizeof(tls_library_version), "GnuTLS %s",
@@ -76,7 +76,7 @@ const char *openconnect_get_tls_library_version()
        return tls_library_version;
 }
 
-int can_enable_insecure_crypto()
+int can_enable_insecure_crypto(void)
 {
        /* XX: As of GnuTLS 3.6.13, no released version has (yet) removed 3DES/RC4 from default builds,
         * but like OpenSSL (removed in 1.1.0) it may happen. */

diff --git a/openssl.c b/openssl.c
index 1a1c134f7b3de220a47e4a25ae70fb9608fdb100..c33908e93f0e9b7bb0d97ee3896bc996b94ed1c6 100644 (file)
--- a/openssl.c
+++ b/openssl.c
@@ -52,7 +52,7 @@ typedef int (*X509_STORE_CTX_get_issuer_fn)(X509 **issuer,
 
 static char tls_library_version[32] = "";
 
-const char *openconnect_get_tls_library_version()
+const char *openconnect_get_tls_library_version(void)
 {
        if (!*tls_library_version) {
                strncpy(tls_library_version, SSLeay_version(SSLEAY_VERSION), sizeof(tls_library_version));
@@ -61,7 +61,7 @@ const char *openconnect_get_tls_library_version()
        return tls_library_version;
 }
 
-int can_enable_insecure_crypto()
+int can_enable_insecure_crypto(void)
 {
        if (EVP_des_ede3_cbc() == NULL ||
            EVP_rc4() == NULL)

diff --git a/ssl.c b/ssl.c
index d5b33da4cb33fbb78fe25bc399c383abebee1339..1f60d5c0047abb772c1a18b48c1e2507a2131931 100644 (file)
--- a/ssl.c
+++ b/ssl.c
@@ -65,7 +65,7 @@
 #endif
 #endif
 
-static inline int connect_pending()
+static inline int connect_pending(void)
 {
 #ifdef _WIN32
        return WSAGetLastError() == WSAEWOULDBLOCK;