various: fix finding metadata inode numbers when metadir is enabled

There are a number of tests that use xfs_db to examine the contents of
metadata inodes to check correct functioning.  The logic is scattered
everywhere and won't work with metadata directory trees, so make a
shared helper to find these inodes.

Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>

diff --git a/common/xfs b/common/xfs
index 0417a40adba3e2520d8e38c4cd45842943bc3779..02f569c971a194f35cc108fd5cf273b9cc7207cf 100644 (file)
--- a/common/xfs
+++ b/common/xfs
@@ -1400,7 +1400,7 @@ _scratch_get_bmx_prefix() {
 
 _scratch_get_iext_count()
 {
-       local ino=$1
+       local selector=$1
        local whichfork=$2
        local field=""
 
@@ -1415,7 +1415,7 @@ _scratch_get_iext_count()
                        return 1
        esac
 
-       _scratch_xfs_get_metadata_field $field "inode $ino"
+       _scratch_xfs_get_metadata_field $field "$selector"
 }
 
 #
@@ -1885,3 +1885,20 @@ _wipe_xfs_properties()
                setfattr --remove="$name" "$1"
        done
 }
+
+# Return the xfs_db selector for a superblock-rooted metadata file on the
+# scratch filesystem.  The sole argument is the name of the field within the
+# superblock.  This helper cannot be used to find files under the metadata
+# directory tree.
+_scratch_xfs_find_metafile()
+{
+       local metafile="$1"
+       local sb_field
+
+       sb_field="$(_scratch_xfs_get_sb_field "$metafile")"
+       if echo "$sb_field" | grep -q -w 'not found'; then
+               return 1
+       fi
+       echo "inode $sb_field"
+       return 0
+}

diff --git a/tests/xfs/007 b/tests/xfs/007
index 2535f04cac36a58ef9a3d775eb3b5c0dbd30fe84..e35a069f9bd5c57f51823efe35f6aeda39a1aa46 100755 (executable)
--- a/tests/xfs/007
+++ b/tests/xfs/007
@@ -21,6 +21,11 @@ _require_xfs_quota
 _scratch_mkfs_xfs | _filter_mkfs > /dev/null 2> $tmp.mkfs
 . $tmp.mkfs
 
+get_qfile_nblocks() {
+       local selector="$(_scratch_xfs_find_metafile "$1")"
+       _scratch_xfs_db -c "$selector" -c "p core.nblocks"
+}
+
 do_test()
 {
        qino_1=$1
@@ -30,12 +35,9 @@ do_test()
        echo "*** umount"
        _scratch_unmount
 
-       QINO_1=`_scratch_xfs_get_sb_field $qino_1`
-       QINO_2=`_scratch_xfs_get_sb_field $qino_2`
-
        echo "*** Usage before quotarm ***"
-       _scratch_xfs_db -c "inode $QINO_1" -c "p core.nblocks"
-       _scratch_xfs_db -c "inode $QINO_2" -c "p core.nblocks"
+       get_qfile_nblocks $qino_1
+       get_qfile_nblocks $qino_2
 
        _qmount
        echo "*** turn off $off_opts quotas"
@@ -65,8 +67,8 @@ do_test()
        _scratch_unmount
 
        echo "*** Usage after quotarm ***"
-       _scratch_xfs_db -c "inode $QINO_1" -c "p core.nblocks"
-       _scratch_xfs_db -c "inode $QINO_2" -c "p core.nblocks"
+       get_qfile_nblocks $qino_1
+       get_qfile_nblocks $qino_2
 }
 
 # Test user and group first

diff --git a/tests/xfs/529 b/tests/xfs/529
index 14bdd2eebf70478bf7f4f8e20fa4d1b9feb7152e..aab8668c76f46c2ef53407ae7875c0c62dad8173 100755 (executable)
--- a/tests/xfs/529
+++ b/tests/xfs/529
@@ -161,9 +161,8 @@ done
 _scratch_unmount >> $seqres.full
 
 echo "Verify uquota inode's extent count"
-uquotino=$(_scratch_xfs_get_metadata_field 'uquotino' 'sb 0')
-
-nextents=$(_scratch_get_iext_count $uquotino data || \
+selector="$(_scratch_xfs_find_metafile uquotino)"
+nextents=$(_scratch_get_iext_count "$selector" data || \
                   _fail "Unable to obtain inode fork's extent count")
 if (( $nextents > 10 )); then
        echo "Extent count overflow check failed: nextents = $nextents"

diff --git a/tests/xfs/530 b/tests/xfs/530
index 95ab32f1e1f828ef5d012ab6db97af5094aca61d..4a41127e3b820f68b9119481cf4d3380b2de95ee 100755 (executable)
--- a/tests/xfs/530
+++ b/tests/xfs/530
@@ -102,10 +102,8 @@ _scratch_unmount >> $seqres.full
 
 echo "Verify rbmino's and rsumino's extent count"
 for rtino in rbmino rsumino; do
-       ino=$(_scratch_xfs_get_metadata_field $rtino "sb 0")
-       echo "$rtino = $ino" >> $seqres.full
-
-       nextents=$(_scratch_get_iext_count $ino data || \
+       selector="$(_scratch_xfs_find_metafile "$rtino")"
+       nextents=$(_scratch_get_iext_count "$selector" data || \
                        _fail "Unable to obtain inode fork's extent count")
        if (( $nextents > 10 )); then
                echo "Extent count overflow check failed: nextents = $nextents"

diff --git a/tests/xfs/739 b/tests/xfs/739
index 52c90b91b218dfe855dc9df6bad01cd705b0aaa4..5fd6caa5bce2f814b60500292d4215ba20ea976a 100755 (executable)
--- a/tests/xfs/739
+++ b/tests/xfs/739
@@ -25,13 +25,8 @@ echo "Format and populate"
 _scratch_populate_cached nofill > $seqres.full 2>&1
 
 echo "Fuzz rtbitmap"
-is_metadir=$(_scratch_xfs_get_metadata_field "core.version" 'path -m /realtime/0.bitmap')
-if [ -n "$is_metadir" ]; then
-       path=('path -m /realtime/0.bitmap')
-else
-       path=('sb' 'addr rbmino')
-fi
-_scratch_xfs_fuzz_metadata '' 'online' "${path[@]}" 'dblock 0' >> $seqres.full
+path="$(_scratch_xfs_find_metafile rbmino)"
+_scratch_xfs_fuzz_metadata '' 'online' "$path" 'dblock 0' >> $seqres.full
 echo "Done fuzzing rtbitmap"
 
 # success, all done

diff --git a/tests/xfs/740 b/tests/xfs/740
index fb616a16362a6c4649f886954bcd62468c806ec7..c8990034773b32a1c70177dfcb9258e4aca1ac7a 100755 (executable)
--- a/tests/xfs/740
+++ b/tests/xfs/740
@@ -25,13 +25,8 @@ echo "Format and populate"
 _scratch_populate_cached nofill > $seqres.full 2>&1
 
 echo "Fuzz rtsummary"
-is_metadir=$(_scratch_xfs_get_metadata_field "core.version" 'path -m /realtime/0.summary')
-if [ -n "$is_metadir" ]; then
-       path=('path -m /realtime/0.summary')
-else
-       path=('sb' 'addr rsumino')
-fi
-_scratch_xfs_fuzz_metadata '' 'online' "${path[@]}" 'dblock 0' >> $seqres.full
+path="$(_scratch_xfs_find_metafile rsumino)"
+_scratch_xfs_fuzz_metadata '' 'online' "$path" 'dblock 0' >> $seqres.full
 echo "Done fuzzing rtsummary"
 
 # success, all done

diff --git a/tests/xfs/741 b/tests/xfs/741
index ea1c2d98516fdbbbd48aaa608177291de8e40449..96c2315c5243114ba66e2d29a51b55d5b3eafe9f 100755 (executable)
--- a/tests/xfs/741
+++ b/tests/xfs/741
@@ -25,13 +25,8 @@ echo "Format and populate"
 _scratch_populate_cached nofill > $seqres.full 2>&1
 
 echo "Fuzz rtbitmap"
-is_metadir=$(_scratch_xfs_get_metadata_field "core.version" 'path -m /realtime/0.bitmap')
-if [ -n "$is_metadir" ]; then
-       path=('path -m /realtime/0.bitmap')
-else
-       path=('sb' 'addr rbmino')
-fi
-_scratch_xfs_fuzz_metadata '' 'offline' "${path[@]}" 'dblock 0' >> $seqres.full
+path="$(_scratch_xfs_find_metafile rbmino)"
+_scratch_xfs_fuzz_metadata '' 'offline' "$path" 'dblock 0' >> $seqres.full
 echo "Done fuzzing rtbitmap"
 
 # success, all done

diff --git a/tests/xfs/742 b/tests/xfs/742
index bbc186f8472b6405771664f80ae8b0b1b5261f17..301ae7b95743208ee3b72fc5ca420e904ee54a6a 100755 (executable)
--- a/tests/xfs/742
+++ b/tests/xfs/742
@@ -25,13 +25,8 @@ echo "Format and populate"
 _scratch_populate_cached nofill > $seqres.full 2>&1
 
 echo "Fuzz rtsummary"
-is_metadir=$(_scratch_xfs_get_metadata_field "core.version" 'path -m /realtime/0.summary')
-if [ -n "$is_metadir" ]; then
-       path=('path -m /realtime/0.summary')
-else
-       path=('sb' 'addr rsumino')
-fi
-_scratch_xfs_fuzz_metadata '' 'offline' "${path[@]}" 'dblock 0' >> $seqres.full
+path="$(_scratch_xfs_find_metafile rsumino)"
+_scratch_xfs_fuzz_metadata '' 'offline' "$path" 'dblock 0' >> $seqres.full
 echo "Done fuzzing rtsummary"
 
 # success, all done

diff --git a/tests/xfs/743 b/tests/xfs/743
index 8021d7ecdc9009da7b946324ac76941eb92ba2d3..039624f711c0a61e2528c74aa924df1e33134f70 100755 (executable)
--- a/tests/xfs/743
+++ b/tests/xfs/743
@@ -26,13 +26,8 @@ echo "Format and populate"
 _scratch_populate_cached nofill > $seqres.full 2>&1
 
 echo "Fuzz rtbitmap"
-is_metadir=$(_scratch_xfs_get_metadata_field "core.version" 'path -m /realtime/0.bitmap')
-if [ -n "$is_metadir" ]; then
-       path=('path -m /realtime/0.bitmap')
-else
-       path=('sb' 'addr rbmino')
-fi
-_scratch_xfs_fuzz_metadata '' 'both' "${path[@]}" 'dblock 0' >> $seqres.full
+path="$(_scratch_xfs_find_metafile rbmino)"
+_scratch_xfs_fuzz_metadata '' 'both' "$path" 'dblock 0' >> $seqres.full
 echo "Done fuzzing rtbitmap"
 
 # success, all done

diff --git a/tests/xfs/744 b/tests/xfs/744
index 0e719dcebf03d2245d46b69b1e6004db7afba48f..13f63b9ceb1756d49e28030d60aabe7e6b64640e 100755 (executable)
--- a/tests/xfs/744
+++ b/tests/xfs/744
@@ -26,13 +26,8 @@ echo "Format and populate"
 _scratch_populate_cached nofill > $seqres.full 2>&1
 
 echo "Fuzz rtsummary"
-is_metadir=$(_scratch_xfs_get_metadata_field "core.version" 'path -m /realtime/0.summary')
-if [ -n "$is_metadir" ]; then
-       path=('path -m /realtime/0.summary')
-else
-       path=('sb' 'addr rsumino')
-fi
-_scratch_xfs_fuzz_metadata '' 'both' "${path[@]}" 'dblock 0' >> $seqres.full
+path="$(_scratch_xfs_find_metafile rsumino)"
+_scratch_xfs_fuzz_metadata '' 'both' "$path" 'dblock 0' >> $seqres.full
 echo "Done fuzzing rtsummary"
 
 # success, all done

diff --git a/tests/xfs/745 b/tests/xfs/745
index 3549ad08772c2c773da9d515e1fb19efd0746617..56a6d58ef9f4ca4d531ae0cd6cf01a658f70020d 100755 (executable)
--- a/tests/xfs/745
+++ b/tests/xfs/745
@@ -25,13 +25,8 @@ echo "Format and populate"
 _scratch_populate_cached nofill > $seqres.full 2>&1
 
 echo "Fuzz rtbitmap"
-is_metadir=$(_scratch_xfs_get_metadata_field "core.version" 'path -m /realtime/0.bitmap')
-if [ -n "$is_metadir" ]; then
-       path=('path -m /realtime/0.bitmap')
-else
-       path=('sb' 'addr rbmino')
-fi
-_scratch_xfs_fuzz_metadata '' 'none' "${path[@]}" 'dblock 0' >> $seqres.full
+path="$(_scratch_xfs_find_metafile rbmino)"
+_scratch_xfs_fuzz_metadata '' 'none' "$path" 'dblock 0' >> $seqres.full
 echo "Done fuzzing rtbitmap"
 
 # success, all done

diff --git a/tests/xfs/746 b/tests/xfs/746
index 5afc71ad19c6e62faa3218162041c923d884f316..935b2e5acba5d4234060836ee4208393a8d99388 100755 (executable)
--- a/tests/xfs/746
+++ b/tests/xfs/746
@@ -25,13 +25,8 @@ echo "Format and populate"
 _scratch_populate_cached nofill > $seqres.full 2>&1
 
 echo "Fuzz rtsummary"
-is_metadir=$(_scratch_xfs_get_metadata_field "core.version" 'path -m /realtime/0.summary')
-if [ -n "$is_metadir" ]; then
-       path=('path -m /realtime/0.summary')
-else
-       path=('sb' 'addr rsumino')
-fi
-_scratch_xfs_fuzz_metadata '' 'none' "${path[@]}" 'dblock 0' >> $seqres.full
+path="$(_scratch_xfs_find_metafile rsumino)"
+_scratch_xfs_fuzz_metadata '' 'none' "$path" 'dblock 0' >> $seqres.full
 echo "Done fuzzing rtsummary"
 
 # success, all done