]> www.infradead.org Git - users/willy/xarray.git/commitdiff
io_uring: fix skipping disabling sqo on exec
authorPavel Begunkov <asml.silence@gmail.com>
Sun, 17 Jan 2021 02:29:56 +0000 (02:29 +0000)
committerJens Axboe <axboe@kernel.dk>
Sun, 17 Jan 2021 04:02:49 +0000 (21:02 -0700)
If there are no requests at the time __io_uring_task_cancel() is called,
tctx_inflight() returns zero and and it terminates not getting a chance
to go through __io_uring_files_cancel() and do
io_disable_sqo_submit(). And we absolutely want them disabled by the
time cancellation ends.

Reported-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Fixes: d9d05217cb69 ("io_uring: stop SQPOLL submit on creator's death")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/io_uring.c

index d494c4269fc5e9b5f4d619a8d573406154b18e26..383ff6ed373428688f446b998038682a3704ab4e 100644 (file)
@@ -9085,6 +9085,10 @@ void __io_uring_task_cancel(void)
        /* make sure overflow events are dropped */
        atomic_inc(&tctx->in_idle);
 
+       /* trigger io_disable_sqo_submit() */
+       if (tctx->sqpoll)
+               __io_uring_files_cancel(NULL);
+
        do {
                /* read completions before cancelations */
                inflight = tctx_inflight(tctx);