]> www.infradead.org Git - users/dwmw2/openconnect.git/commitdiff
Refuse to handle forms without ->auth_id
authorDavid Woodhouse <dwmw2@infradead.org>
Tue, 4 May 2021 11:11:17 +0000 (12:11 +0100)
committerDavid Woodhouse <dwmw2@infradead.org>
Tue, 4 May 2021 11:33:19 +0000 (12:33 +0100)
GUI authentication dialogs will really want this for saving responses.
And saved_form_field() will crash if it's NULL too.

Signed-off-by: David Woodhouse <dwmw2@infradead.org>
main.c

diff --git a/main.c b/main.c
index c43f87311bc863c2644b232b47121789e5b767cf..722f4d9ccaac4a4384b15caeb98a1020fc4929ff 100644 (file)
--- a/main.c
+++ b/main.c
@@ -2494,6 +2494,9 @@ static int process_auth_form_cb(void *_vpninfo,
        struct oc_form_opt *opt;
        int empty = 1;
 
+       if (!form->auth_id)
+               return -EINVAL;
+
        if (form->banner && verbose > PRG_ERR)
                fprintf(stderr, "%s\n", form->banner);