i2c: at91: Use dev_err_probe() instead of dev_err()

Change
if (IS_ERR(x)) { dev_err(...); return PTR_ERR(x); }
into
return dev_err_probe()

Also, return the correct error instead of hardcoding -ENODEV
This change has also the advantage of handling the -EPROBE_DEFER situation.

Signed-off-by: Yann Sionneau <yann@sionneau.net>
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Signed-off-by: Wolfram Sang <wsa@kernel.org>

diff --git a/drivers/i2c/busses/i2c-at91-core.c b/drivers/i2c/busses/i2c-at91-core.c
index 91d66ec145884ee0a696e99a033a191a96f9bacf..db45554327aedcb7c92d76d774fe624ab9608f57 100644 (file)
--- a/drivers/i2c/busses/i2c-at91-core.c
+++ b/drivers/i2c/busses/i2c-at91-core.c
@@ -222,10 +222,9 @@ static int at91_twi_probe(struct platform_device *pdev)
        platform_set_drvdata(pdev, dev);
 
        dev->clk = devm_clk_get(dev->dev, NULL);
-       if (IS_ERR(dev->clk)) {
-               dev_err(dev->dev, "no clock defined\n");
-               return -ENODEV;
-       }
+       if (IS_ERR(dev->clk))
+               return dev_err_probe(dev->dev, PTR_ERR(dev->clk), "no clock defined\n");
+
        clk_prepare_enable(dev->clk);
 
        snprintf(dev->adapter.name, sizeof(dev->adapter.name), "AT91");