]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
dmaengine: ti: edma: make the loop condition simpler in edma_probe()
authorJoe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Thu, 19 Dec 2024 02:05:06 +0000 (11:05 +0900)
committerVinod Koul <vkoul@kernel.org>
Tue, 24 Dec 2024 09:53:32 +0000 (15:23 +0530)
When i == ecc->num_tc, the edma_probe() calls
of_parse_phandle_with_fixed_args() and breaks from the loop regardless
of the return value. Since neither the returned value nor the output
argument tc_args is used, set i < ecc->num_tc as the loop condition.

Signed-off-by: Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Link: https://lore.kernel.org/r/20241219020507.1983124-2-joe@pf.is.s.u-tokyo.ac.jp
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/ti/edma.c

index 343e986e66e7ce0ccf2b9a4fccedb04cdcc36500..08f6c67d381e6722ae61ac364b40fa92fe7af8ba 100644 (file)
@@ -2460,10 +2460,10 @@ static int edma_probe(struct platform_device *pdev)
                        goto err_reg1;
                }
 
-               for (i = 0;; i++) {
+               for (i = 0; i < ecc->num_tc; i++) {
                        ret = of_parse_phandle_with_fixed_args(node, "ti,tptcs",
                                                               1, i, &tc_args);
-                       if (ret || i == ecc->num_tc)
+                       if (ret)
                                break;
 
                        ecc->tc_list[i].node = tc_args.np;