smb: client: Return a status code only as a constant in cifs_spnego_key_instantiate()

* Return a status code without storing it in an intermediate variable.

* Delete the local variable “ret” and the label “error”
  which became unnecessary with this refactoring.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Enzo Matsumiya <ematsumiya@suse.de>
Signed-off-by: Steve French <stfrench@microsoft.com>

diff --git a/fs/smb/client/cifs_spnego.c b/fs/smb/client/cifs_spnego.c
index 43b86fa4d695ca3455e11bf42945e6b61ba668f8..9891f55bac1e28f37247505a87f9a0b6a16f66d2 100644 (file)
--- a/fs/smb/client/cifs_spnego.c
+++ b/fs/smb/client/cifs_spnego.c
@@ -24,20 +24,14 @@ static const struct cred *spnego_cred;
 static int
 cifs_spnego_key_instantiate(struct key *key, struct key_preparsed_payload *prep)
 {
-       char *payload;
-       int ret;
+       char *payload = kmemdup(prep->data, prep->datalen, GFP_KERNEL);
 
-       ret = -ENOMEM;
-       payload = kmemdup(prep->data, prep->datalen, GFP_KERNEL);
        if (!payload)
-               goto error;
+               return -ENOMEM;
 
        /* attach the data */
        key->payload.data[0] = payload;
-       ret = 0;
-
-error:
-       return ret;
+       return 0;
 }
 
 static void