]> www.infradead.org Git - linux-platform-drivers-x86.git/commitdiff
drm/i915/gvt: avoid useless use of inline
authorJani Nikula <jani.nikula@intel.com>
Mon, 30 Nov 2020 11:13:53 +0000 (13:13 +0200)
committerZhenyu Wang <zhenyuw@linux.intel.com>
Thu, 3 Dec 2020 05:29:01 +0000 (13:29 +0800)
In most cases, we are better off letting the compiler decide whether to
inline static functions in .c files or not. In this case, the inline
will be ignored anyway as mmio_pm_restore_handler() is passed as a
function pointer.

Fixes: 5f60b12edcd0 ("drm/i915/gvt: Save/restore HW status to support GVT suspend/resume")
Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
Cc: Hang Yuan <hang.yuan@linux.intel.com>
Cc: Colin Xu <colin.xu@intel.com>
Cc: Zhi Wang <zhi.a.wang@intel.com>
Cc: intel-gvt-dev@lists.freedesktop.org
Reviewed-by: Zhenyu Wang <zhenyuw@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20201130111353.25406-1-jani.nikula@intel.com
drivers/gpu/drm/i915/gvt/handlers.c

index 62b49c72a7d09f5b296bcf3f8e5da6e8c3acee5f..aa02d555682262218344ba809242ee71ddc68306 100644 (file)
@@ -3645,8 +3645,7 @@ void intel_gvt_restore_fence(struct intel_gvt *gvt)
        }
 }
 
-static inline int mmio_pm_restore_handler(struct intel_gvt *gvt,
-                                         u32 offset, void *data)
+static int mmio_pm_restore_handler(struct intel_gvt *gvt, u32 offset, void *data)
 {
        struct intel_vgpu *vgpu = data;
        struct drm_i915_private *dev_priv = gvt->gt->i915;