]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
drm/bridge: megachips-stdpxxxx-ge-b850v3-fw: Remove a redundant check on existence...
authorSui Jingfeng <sui.jingfeng@linux.dev>
Mon, 13 May 2024 15:31:05 +0000 (23:31 +0800)
committerRobert Foss <rfoss@kernel.org>
Mon, 13 May 2024 16:31:07 +0000 (18:31 +0200)
In the ge_b850v3_lvds_create_connector function, the check on the existence
of bridge->encoder is not necessary, as it has already been checked in the
drm_bridge_attach() function called by upstream bridge or driver. Hence, it
is guaranteed that the .encoder member of the drm_bridge instance is not
NULL when cdns_mhdp_connector_init() function get called.

Remove the redundant checking codes "if (!bridge->encoder) { ... }".

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Sui Jingfeng <sui.jingfeng@linux.dev>
Signed-off-by: Robert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240513153109.46786-9-sui.jingfeng@linux.dev
drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c

index 4480523244e4e29806469a84a485668d54b969a3..37f1acf5c0f83ded2fb3d83150dc05cb6cfd2432 100644 (file)
@@ -165,11 +165,6 @@ static int ge_b850v3_lvds_create_connector(struct drm_bridge *bridge)
        struct drm_connector *connector = &ge_b850v3_lvds_ptr->connector;
        int ret;
 
-       if (!bridge->encoder) {
-               DRM_ERROR("Parent encoder object not found");
-               return -ENODEV;
-       }
-
        connector->polled = DRM_CONNECTOR_POLL_HPD;
 
        drm_connector_helper_add(connector,