wifi: iwlwifi: make ppag versioning clear

We used to have in iwl_ppag_table_cmd v2, that covered multiple FW
versions of the command (2-6), so we just called it v2, and v3 for FW
version 7. This is a bit confusing, and now v2 actually covers only FW
version 5. Rename v2 to v5 and v3 to v7 so we don't have a different
versioning than the FW has.

Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20250821204455.e1240c6889e5.If7898bdf9ef70eed9c12484c03a3cc4f27635682@changeid

diff --git a/drivers/net/wireless/intel/iwlwifi/fw/api/power.h b/drivers/net/wireless/intel/iwlwifi/fw/api/power.h
index ab84aac6605d46c31273e116bf7e2821931e8921..5eb8d10678fd4c0252d77976a7186586671c303c 100644 (file)
--- a/drivers/net/wireless/intel/iwlwifi/fw/api/power.h
+++ b/drivers/net/wireless/intel/iwlwifi/fw/api/power.h
@@ -571,16 +571,16 @@ enum iwl_ppag_flags {
 /**
  * union iwl_ppag_table_cmd - union for all versions of PPAG command
  * @v1: command version 1 structure.
- * @v2: command version 5 structure.
- * @v3: command version 7 structure.
+ * @v5: command version 5 structure.
+ * @v7: command version 7 structure.
  * @v1.flags: values from &enum iwl_ppag_flags
  * @v1.gain: table of antenna gain values per chain and sub-band
  * @v1.reserved: reserved
- * @v2.flags: values from &enum iwl_ppag_flags
- * @v2.gain: table of antenna gain values per chain and sub-band
- * @v3.ppag_config_info: see @struct bios_value_u32
- * @v3.gain: table of antenna gain values per chain and sub-band
- * @v3.reserved: reserved
+ * @v5.flags: values from &enum iwl_ppag_flags
+ * @v5.gain: table of antenna gain values per chain and sub-band
+ * @v7.ppag_config_info: see @struct bios_value_u32
+ * @v7.gain: table of antenna gain values per chain and sub-band
+ * @v7.reserved: reserved
  */
 union iwl_ppag_table_cmd {
        struct {
@@ -592,12 +592,12 @@ union iwl_ppag_table_cmd {
                __le32 flags;
                s8 gain[IWL_NUM_CHAIN_LIMITS][IWL_NUM_SUB_BANDS_V2];
                s8 reserved[2];
-       } __packed v2; /* PER_PLAT_ANTENNA_GAIN_CMD_API_S_VER_5 */
+       } __packed v5; /* PER_PLAT_ANTENNA_GAIN_CMD_API_S_VER_5 */
        struct {
                struct bios_value_u32 ppag_config_info;
                s8 gain[IWL_NUM_CHAIN_LIMITS][IWL_NUM_SUB_BANDS_V2];
                s8 reserved[2];
-       } __packed v3; /* PER_PLAT_ANTENNA_GAIN_CMD_API_S_VER_7 */
+       } __packed v7; /* PER_PLAT_ANTENNA_GAIN_CMD_API_S_VER_7 */
 } __packed;
 
 #define IWL_PPAG_CMD_V1_MASK (IWL_PPAG_ETSI_MASK | IWL_PPAG_CHINA_MASK)

diff --git a/drivers/net/wireless/intel/iwlwifi/fw/regulatory.c b/drivers/net/wireless/intel/iwlwifi/fw/regulatory.c
index 80d8373fccfcd922be4eff039350400b831ea271..00921f86286a08954de8dd7f0614727a792531b6 100644 (file)
--- a/drivers/net/wireless/intel/iwlwifi/fw/regulatory.c
+++ b/drivers/net/wireless/intel/iwlwifi/fw/regulatory.c
@@ -353,9 +353,9 @@ int iwl_fill_ppag_table(struct iwl_fw_runtime *fwrt,
                }
        } else if (cmd_ver == 5) {
                num_sub_bands = IWL_NUM_SUB_BANDS_V2;
-               gain = cmd->v2.gain[0];
-               *cmd_size = sizeof(cmd->v2);
-               cmd->v2.flags = cpu_to_le32(fwrt->ppag_flags & IWL_PPAG_CMD_V5_MASK);
+               gain = cmd->v5.gain[0];
+               *cmd_size = sizeof(cmd->v5);
+               cmd->v5.flags = cpu_to_le32(fwrt->ppag_flags & IWL_PPAG_CMD_V5_MASK);
                if (fwrt->ppag_bios_rev == 0) {
                        /* in this case FW supports revisions 1,2 or 3 */
                        IWL_DEBUG_RADIO(fwrt,
@@ -363,11 +363,11 @@ int iwl_fill_ppag_table(struct iwl_fw_runtime *fwrt,
                }
        } else if (cmd_ver == 7) {
                num_sub_bands = IWL_NUM_SUB_BANDS_V2;
-               gain = cmd->v3.gain[0];
-               *cmd_size = sizeof(cmd->v3);
-               cmd->v3.ppag_config_info.table_source = fwrt->ppag_bios_source;
-               cmd->v3.ppag_config_info.table_revision = fwrt->ppag_bios_rev;
-               cmd->v3.ppag_config_info.value = cpu_to_le32(fwrt->ppag_flags);
+               gain = cmd->v7.gain[0];
+               *cmd_size = sizeof(cmd->v7);
+               cmd->v7.ppag_config_info.table_source = fwrt->ppag_bios_source;
+               cmd->v7.ppag_config_info.table_revision = fwrt->ppag_bios_rev;
+               cmd->v7.ppag_config_info.value = cpu_to_le32(fwrt->ppag_flags);
        } else {
                IWL_DEBUG_RADIO(fwrt, "Unsupported PPAG command version\n");
                return -EINVAL;
@@ -387,13 +387,13 @@ int iwl_fill_ppag_table(struct iwl_fw_runtime *fwrt,
                IWL_DEBUG_RADIO(fwrt, "isn't masking ppag China bit\n");
        }
 
-       /* The 'flags' field is the same in v1 and v2 so we can just
+       /* The 'flags' field is the same in v1 and v5 so we can just
         * use v1 to access it.
         */
        IWL_DEBUG_RADIO(fwrt,
                        "PPAG MODE bits going to be sent: %d\n",
                        (cmd_ver < 7) ? le32_to_cpu(cmd->v1.flags) :
-                                       le32_to_cpu(cmd->v3.ppag_config_info.value));
+                                       le32_to_cpu(cmd->v7.ppag_config_info.value));
 
        for (i = 0; i < IWL_NUM_CHAIN_LIMITS; i++) {
                for (j = 0; j < num_sub_bands; j++) {