]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
bnxt_en: Do not setup PHY unless driving a single PF.
authorMichael Chan <michael.chan@broadcom.com>
Mon, 13 Feb 2017 00:18:15 +0000 (19:18 -0500)
committerChuck Anderson <chuck.anderson@oracle.com>
Mon, 6 Mar 2017 21:35:39 +0000 (13:35 -0800)
Orabug: 25645429

If it is a VF or an NPAR function, the firmware call to setup the PHY
will fail.  Adding this check will prevent unnecessary firmware calls
to setup the PHY unless calling from the PF.  This will also eliminate
many unnecessary warning messages when the call from a VF or NPAR fails.

Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit 33dac24abbd5a77eefca18fb7ebbd01a3cf1b343)
Signed-off-by: Brian Maly <brian.maly@oracle.com>
drivers/net/ethernet/broadcom/bnxt/bnxt.c

index 53d7db3534210a1e58231916004845e7f4251391..d3530c27e478b68a743548f6bd8bbd75a9dbc7bf 100644 (file)
@@ -5845,6 +5845,9 @@ static int bnxt_update_phy_setting(struct bnxt *bp)
                           rc);
                return rc;
        }
+       if (!BNXT_SINGLE_PF(bp))
+               return 0;
+
        if ((link_info->autoneg & BNXT_AUTONEG_FLOW_CTRL) &&
            (link_info->auto_pause_setting & BNXT_LINK_PAUSE_BOTH) !=
            link_info->req_flow_ctrl)