]> www.infradead.org Git - users/hch/misc.git/commitdiff
PCI/AER: Fix NULL pointer access by aer_info
authorVernon Yang <yanglincheng@kylinos.cn>
Thu, 4 Sep 2025 18:25:27 +0000 (02:25 +0800)
committerBjorn Helgaas <bhelgaas@google.com>
Thu, 11 Sep 2025 22:55:33 +0000 (17:55 -0500)
The kzalloc(GFP_KERNEL) may return NULL, so all accesses to aer_info->xxx
will result in kernel panic. Fix it.

Signed-off-by: Vernon Yang <yanglincheng@kylinos.cn>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Link: https://patch.msgid.link/20250904182527.67371-1-vernon2gm@gmail.com
drivers/pci/pcie/aer.c

index 62c74b5f99aecadd8ab93cf42c3477893af9f899..cd0f0b17f0973924ef9b66a13bb2d638be5238c4 100644 (file)
@@ -393,6 +393,10 @@ void pci_aer_init(struct pci_dev *dev)
                return;
 
        dev->aer_info = kzalloc(sizeof(*dev->aer_info), GFP_KERNEL);
+       if (!dev->aer_info) {
+               dev->aer_cap = 0;
+               return;
+       }
 
        ratelimit_state_init(&dev->aer_info->correctable_ratelimit,
                             DEFAULT_RATELIMIT_INTERVAL, DEFAULT_RATELIMIT_BURST);