blk-cgroup: pass a gendisk to pd_alloc_fn

No need to the request_queue here, pass a gendisk and extract the
node ids from that.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Andreas Herrmann <aherrmann@suse.de>
Acked-by: Tejun Heo <tj@kernel.org>
Link: https://lore.kernel.org/r/20230203150400.3199230-18-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>

diff --git a/block/bfq-cgroup.c b/block/bfq-cgroup.c
index 032c14f0451a1de5b92f75e1cdd846c259d606c4..37333c164ed458f8a48d12bbed67980221030288 100644 (file)
--- a/block/bfq-cgroup.c
+++ b/block/bfq-cgroup.c
@@ -513,12 +513,12 @@ static void bfq_cpd_free(struct blkcg_policy_data *cpd)
        kfree(cpd_to_bfqgd(cpd));
 }
 
-static struct blkg_policy_data *bfq_pd_alloc(gfp_t gfp, struct request_queue *q,
-                                            struct blkcg *blkcg)
+static struct blkg_policy_data *bfq_pd_alloc(struct gendisk *disk,
+               struct blkcg *blkcg, gfp_t gfp)
 {
        struct bfq_group *bfqg;
 
-       bfqg = kzalloc_node(sizeof(*bfqg), gfp, q->node);
+       bfqg = kzalloc_node(sizeof(*bfqg), gfp, disk->node_id);
        if (!bfqg)
                return NULL;
 

diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
index c20929bce8125ca3d65a68ca32f32dc0d9b9d64e..fc264b155882107fc097923d7d88baef7f07fbad 100644 (file)
--- a/block/blk-cgroup.c
+++ b/block/blk-cgroup.c
@@ -276,7 +276,7 @@ static struct blkcg_gq *blkg_alloc(struct blkcg *blkcg, struct gendisk *disk,
                        continue;
 
                /* alloc per-policy data and attach it to blkg */
-               pd = pol->pd_alloc_fn(gfp_mask, disk->queue, blkcg);
+               pd = pol->pd_alloc_fn(disk, blkcg, gfp_mask);
                if (!pd)
                        goto out_free_pds;
                blkg->pd[i] = pd;
@@ -1432,8 +1432,8 @@ retry:
                        pd = pd_prealloc;
                        pd_prealloc = NULL;
                } else {
-                       pd = pol->pd_alloc_fn(GFP_NOWAIT | __GFP_NOWARN, q,
-                                             blkg->blkcg);
+                       pd = pol->pd_alloc_fn(disk, blkg->blkcg,
+                                             GFP_NOWAIT | __GFP_NOWARN);
                }
 
                if (!pd) {
@@ -1450,8 +1450,8 @@ retry:
 
                        if (pd_prealloc)
                                pol->pd_free_fn(pd_prealloc);
-                       pd_prealloc = pol->pd_alloc_fn(GFP_KERNEL, q,
-                                                      blkg->blkcg);
+                       pd_prealloc = pol->pd_alloc_fn(disk, blkg->blkcg,
+                                                      GFP_KERNEL);
                        if (pd_prealloc)
                                goto retry;
                        else

diff --git a/block/blk-cgroup.h b/block/blk-cgroup.h
index 27068faa2cd0860ce755f8a9c20fa8f910955739..3d9e42c519db861c5af22d3a71d13e6b44a4fe31 100644 (file)
--- a/block/blk-cgroup.h
+++ b/block/blk-cgroup.h
@@ -154,8 +154,8 @@ typedef struct blkcg_policy_data *(blkcg_pol_alloc_cpd_fn)(gfp_t gfp);
 typedef void (blkcg_pol_init_cpd_fn)(struct blkcg_policy_data *cpd);
 typedef void (blkcg_pol_free_cpd_fn)(struct blkcg_policy_data *cpd);
 typedef void (blkcg_pol_bind_cpd_fn)(struct blkcg_policy_data *cpd);
-typedef struct blkg_policy_data *(blkcg_pol_alloc_pd_fn)(gfp_t gfp,
-                               struct request_queue *q, struct blkcg *blkcg);
+typedef struct blkg_policy_data *(blkcg_pol_alloc_pd_fn)(struct gendisk *disk,
+               struct blkcg *blkcg, gfp_t gfp);
 typedef void (blkcg_pol_init_pd_fn)(struct blkg_policy_data *pd);
 typedef void (blkcg_pol_online_pd_fn)(struct blkg_policy_data *pd);
 typedef void (blkcg_pol_offline_pd_fn)(struct blkg_policy_data *pd);

diff --git a/block/blk-iocost.c b/block/blk-iocost.c
index 078b77709519620fbf32de7ef884f0c64e081f8c..7a2dc9dc8e3ba0e7af16bc160712cae29ffe6c6f 100644 (file)
--- a/block/blk-iocost.c
+++ b/block/blk-iocost.c
@@ -2923,13 +2923,14 @@ static void ioc_cpd_free(struct blkcg_policy_data *cpd)
        kfree(container_of(cpd, struct ioc_cgrp, cpd));
 }
 
-static struct blkg_policy_data *ioc_pd_alloc(gfp_t gfp, struct request_queue *q,
-                                            struct blkcg *blkcg)
+static struct blkg_policy_data *ioc_pd_alloc(struct gendisk *disk,
+               struct blkcg *blkcg, gfp_t gfp)
 {
        int levels = blkcg->css.cgroup->level + 1;
        struct ioc_gq *iocg;
 
-       iocg = kzalloc_node(struct_size(iocg, ancestors, levels), gfp, q->node);
+       iocg = kzalloc_node(struct_size(iocg, ancestors, levels), gfp,
+                           disk->node_id);
        if (!iocg)
                return NULL;
 

diff --git a/block/blk-iolatency.c b/block/blk-iolatency.c
index 39853fc5c2b02f945ecd2af53fbd5a73cae236c6..bc0d217f5c17236dbf68fa63a5b7a88d65e4e283 100644 (file)
--- a/block/blk-iolatency.c
+++ b/block/blk-iolatency.c
@@ -946,13 +946,12 @@ static void iolatency_pd_stat(struct blkg_policy_data *pd, struct seq_file *s)
                        iolat->max_depth, avg_lat, cur_win);
 }
 
-static struct blkg_policy_data *iolatency_pd_alloc(gfp_t gfp,
-                                                  struct request_queue *q,
-                                                  struct blkcg *blkcg)
+static struct blkg_policy_data *iolatency_pd_alloc(struct gendisk *disk,
+               struct blkcg *blkcg, gfp_t gfp)
 {
        struct iolatency_grp *iolat;
 
-       iolat = kzalloc_node(sizeof(*iolat), gfp, q->node);
+       iolat = kzalloc_node(sizeof(*iolat), gfp, disk->node_id);
        if (!iolat)
                return NULL;
        iolat->stats = __alloc_percpu_gfp(sizeof(struct latency_stat),

diff --git a/block/blk-ioprio.c b/block/blk-ioprio.c
index 8194826cc824bce151795899a04d2ff5cfe786f1..055529b9b92bab5de70e689d76f536345d4067c3 100644 (file)
--- a/block/blk-ioprio.c
+++ b/block/blk-ioprio.c
@@ -116,7 +116,7 @@ static ssize_t ioprio_set_prio_policy(struct kernfs_open_file *of, char *buf,
 }
 
 static struct blkg_policy_data *
-ioprio_alloc_pd(gfp_t gfp, struct request_queue *q, struct blkcg *blkcg)
+ioprio_alloc_pd(struct gendisk *disk, struct blkcg *blkcg, gfp_t gfp)
 {
        struct ioprio_blkg *ioprio_blkg;
 

diff --git a/block/blk-throttle.c b/block/blk-throttle.c
index efc0a9092c694255d58f6b185fb1b62a8ac92b2d..74bb1e753ea09de6439ea7cb81f3324fb21a9dd6 100644 (file)
--- a/block/blk-throttle.c
+++ b/block/blk-throttle.c
@@ -335,14 +335,13 @@ static void throtl_service_queue_init(struct throtl_service_queue *sq)
        timer_setup(&sq->pending_timer, throtl_pending_timer_fn, 0);
 }
 
-static struct blkg_policy_data *throtl_pd_alloc(gfp_t gfp,
-                                               struct request_queue *q,
-                                               struct blkcg *blkcg)
+static struct blkg_policy_data *throtl_pd_alloc(struct gendisk *disk,
+               struct blkcg *blkcg, gfp_t gfp)
 {
        struct throtl_grp *tg;
        int rw;
 
-       tg = kzalloc_node(sizeof(*tg), gfp, q->node);
+       tg = kzalloc_node(sizeof(*tg), gfp, disk->node_id);
        if (!tg)
                return NULL;