]> www.infradead.org Git - users/hch/misc.git/commitdiff
accel/rocket: Fix some error checking in rocket_core_init()
authorDan Carpenter <dan.carpenter@linaro.org>
Thu, 21 Aug 2025 12:30:19 +0000 (15:30 +0300)
committerTomeu Vizoso <tomeu@tomeuvizoso.net>
Mon, 1 Sep 2025 10:11:28 +0000 (12:11 +0200)
The problem is that pm_runtime_get_sync() can return 1 on success so
checking for zero doesn't work.  Use the pm_runtime_resume_and_get()
function instead.  The pm_runtime_resume_and_get() function does
additional cleanup as well so that's a bonus as well.

Fixes: 0810d5ad88a1 ("accel/rocket: Add job submission IOCTL")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Tomeu Vizoso <tomeu@tomeuvizoso.net>
Link: https://lore.kernel.org/r/aKcRW6fsRP_o5C_y@stanley.mountain
drivers/accel/rocket/rocket_core.c

index 72fb5e5798fac8d01f351f16a1da0539f042d02e..abe7719c1db468716ec0a229bed467d3ca939cb2 100644 (file)
@@ -74,7 +74,7 @@ int rocket_core_init(struct rocket_core *core)
 
        pm_runtime_enable(dev);
 
-       err = pm_runtime_get_sync(dev);
+       err = pm_runtime_resume_and_get(dev);
        if (err) {
                rocket_job_fini(core);
                return err;