]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
net: bcmgenet: check return value after calling platform_get_resource()
authorYang Yingliang <yangyingliang@huawei.com>
Mon, 7 Jun 2021 13:38:37 +0000 (21:38 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 20 Jul 2021 14:16:00 +0000 (16:16 +0200)
[ Upstream commit 74325bf0104573c6dfce42837139aeef3f34be76 ]

It will cause null-ptr-deref if platform_get_resource() returns NULL,
we need check the return value.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/broadcom/genet/bcmmii.c

index a5049d637791d404e07329778d373c9dff24cf18..494601c39b847f99c8416f891de21475e425b946 100644 (file)
@@ -428,6 +428,10 @@ static int bcmgenet_mii_register(struct bcmgenet_priv *priv)
        int id, ret;
 
        pres = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+       if (!pres) {
+               dev_err(&pdev->dev, "Invalid resource\n");
+               return -EINVAL;
+       }
        memset(&res, 0, sizeof(res));
        memset(&ppd, 0, sizeof(ppd));