]> www.infradead.org Git - users/hch/block.git/commitdiff
dasd: don't set the discard_alignment queue limit
authorChristoph Hellwig <hch@lst.de>
Fri, 8 Apr 2022 09:35:21 +0000 (11:35 +0200)
committerChristoph Hellwig <hch@lst.de>
Fri, 15 Apr 2022 06:50:02 +0000 (08:50 +0200)
The discard_alignment queue limit is named a bit misleading means the
offset into the block device at which the discard granularity starts.
Setting it to PAGE_SIZE while the discard granularity is the block size
that is smaller or the same as PAGE_SIZE as done by dasd is mostly
harmless but also useless.

Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/s390/block/dasd_fba.c

index 8bd5665db9198bc39dabaf8d9aa3714ddee52d84..60be7f7bf2d167d02e1526cc7367adfd8e0e1642 100644 (file)
@@ -782,7 +782,6 @@ static void dasd_fba_setup_blk_queue(struct dasd_block *block)
        blk_queue_segment_boundary(q, PAGE_SIZE - 1);
 
        q->limits.discard_granularity = logical_block_size;
-       q->limits.discard_alignment = PAGE_SIZE;
 
        /* Calculate max_discard_sectors and make it PAGE aligned */
        max_bytes = USHRT_MAX * logical_block_size;