nvme-rdma: fix error code in nvme_rdma_setup_ctrl

In case that icdoff is not zero or mandatory keyed sgls are not
supported by the NVMe/RDMA target, we'll go to error flow but we'll
return 0 to the caller. Fix it by returning an appropriate error code.

Fixes: c66e2998c8ca ("nvme-rdma: centralize controller setup sequence")
Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Christoph Hellwig <hch@lst.de>

diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
index 5ba386f00c3f1e31e58cb106ef91a21e877ca36c..9317f26e51e0c50c1147cb95e8a287d29b4165c6 100644 (file)
--- a/drivers/nvme/host/rdma.c
+++ b/drivers/nvme/host/rdma.c
@@ -1096,11 +1096,13 @@ static int nvme_rdma_setup_ctrl(struct nvme_rdma_ctrl *ctrl, bool new)
                return ret;
 
        if (ctrl->ctrl.icdoff) {
+               ret = -EOPNOTSUPP;
                dev_err(ctrl->ctrl.device, "icdoff is not supported!\n");
                goto destroy_admin;
        }
 
        if (!(ctrl->ctrl.sgls & (1 << 2))) {
+               ret = -EOPNOTSUPP;
                dev_err(ctrl->ctrl.device,
                        "Mandatory keyed sgls are not supported!\n");
                goto destroy_admin;