]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
Input: elo - fix an error code in elo_connect()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 17 Feb 2021 04:29:05 +0000 (20:29 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Thu, 18 Feb 2021 22:39:42 +0000 (14:39 -0800)
If elo_setup_10() fails then this should return an error code instead
of success.

Fixes: fae3006e4b42 ("Input: elo - add support for non-pressure-sensitive touchscreens")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/YBKFd5CvDu+jVmfW@mwanda
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/touchscreen/elo.c

index e0bacd34866ad0fc28f54d7c067ea2c8d47f2ded..96173232e53fec54a2b74a00f976394a7c624d0d 100644 (file)
@@ -341,8 +341,10 @@ static int elo_connect(struct serio *serio, struct serio_driver *drv)
        switch (elo->id) {
 
        case 0: /* 10-byte protocol */
-               if (elo_setup_10(elo))
+               if (elo_setup_10(elo)) {
+                       err = -EIO;
                        goto fail3;
+               }
 
                break;