tree: do no free ns on error in nvme_ns_init

The ns pointer is owned by the caller not by nvme_ns_init, thus we can't
just free it on error.

Fixes: 7959f52960fd ("tree: read all attributes from sysfs when available")
Reported-by: Tomasz Kłoczko <kloczek@fedoraproject.org>
Signed-off-by: Daniel Wagner <dwagner@suse.de>

diff --git a/src/nvme/tree.c b/src/nvme/tree.c
index 5d1d3bb22244d58ede7ad801527834c5b56b29af..07a3c532f37cc45b051c492aa850aca70cbebe87 100644 (file)
--- a/src/nvme/tree.c
+++ b/src/nvme/tree.c
@@ -2473,7 +2473,7 @@ static int nvme_ns_init(const char *path, struct nvme_ns *ns)
 
                ret = nvme_ns_identify(ns, id);
                if (ret)
-                       free(ns);
+                       return ret;
 
                nvme_id_ns_flbas_to_lbaf_inuse(id->flbas, &flbas);
                ns->lba_count = le64_to_cpu(id->nsze);