]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
ASoC: sma1307: Fix invalid logical judgement
authorTang Bin <tangbin@cmss.chinamobile.com>
Fri, 8 Nov 2024 01:16:17 +0000 (09:16 +0800)
committerMark Brown <broonie@kernel.org>
Fri, 8 Nov 2024 13:33:06 +0000 (13:33 +0000)
In the function sma1307_dai_hw_params_amp, the variable
'ret' has not been assigned a value, so the logical judgement
is invalid, thus fix it.

Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
Link: https://patch.msgid.link/20241108011617.2284-1-tangbin@cmss.chinamobile.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/sma1307.c

index 985a247b3310723ebea5c1122bd99d7df654ead9..81638768ac12541ae5c819f2be340876d849e07f 100644 (file)
@@ -1191,7 +1191,6 @@ static int sma1307_dai_hw_params_amp(struct snd_pcm_substream *substream,
        struct snd_soc_component *component = dai->component;
        struct sma1307_priv *sma1307 = snd_soc_component_get_drvdata(component);
        unsigned int bclk = 0;
-       int ret = 0;
 
        if (sma1307->format == SND_SOC_DAIFMT_DSP_A)
                bclk = params_rate(params) * sma1307->frame_size;
@@ -1336,8 +1335,6 @@ static int sma1307_dai_hw_params_amp(struct snd_pcm_substream *substream,
                        params_format(params));
                return -EINVAL;
        }
-       if (ret < 0)
-               return -EINVAL;
 
        return 0;
 }