]> www.infradead.org Git - users/willy/xarray.git/commitdiff
selftests/bpf: Improve missed_kprobe_recursion test robustness
authorAndrii Nakryiko <andrii@kernel.org>
Wed, 11 Oct 2023 22:37:25 +0000 (15:37 -0700)
committerDaniel Borkmann <daniel@iogearbox.net>
Mon, 16 Oct 2023 11:49:18 +0000 (13:49 +0200)
Given missed_kprobe_recursion is non-serial and uses common testing
kfuncs to count number of recursion misses it's possible that some other
parallel test can trigger extraneous recursion misses. So we can't
expect exactly 1 miss. Relax conditions and expect at least one.

Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Acked-by: John Fastabend <john.fastabend@gmail.com>
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
Link: https://lore.kernel.org/bpf/20231011223728.3188086-3-andrii@kernel.org
tools/testing/selftests/bpf/prog_tests/missed.c

index 24ade11f5c05f2ff6fc4edfe91e2ed320c7de220..70d90c43537c16f782a5ba86bb826403a76db4f5 100644 (file)
@@ -81,10 +81,10 @@ static void test_missed_kprobe_recursion(void)
        ASSERT_EQ(topts.retval, 0, "test_run");
 
        ASSERT_EQ(get_missed_count(bpf_program__fd(skel->progs.test1)), 0, "test1_recursion_misses");
-       ASSERT_EQ(get_missed_count(bpf_program__fd(skel->progs.test2)), 1, "test2_recursion_misses");
-       ASSERT_EQ(get_missed_count(bpf_program__fd(skel->progs.test3)), 1, "test3_recursion_misses");
-       ASSERT_EQ(get_missed_count(bpf_program__fd(skel->progs.test4)), 1, "test4_recursion_misses");
-       ASSERT_EQ(get_missed_count(bpf_program__fd(skel->progs.test5)), 1, "test5_recursion_misses");
+       ASSERT_GE(get_missed_count(bpf_program__fd(skel->progs.test2)), 1, "test2_recursion_misses");
+       ASSERT_GE(get_missed_count(bpf_program__fd(skel->progs.test3)), 1, "test3_recursion_misses");
+       ASSERT_GE(get_missed_count(bpf_program__fd(skel->progs.test4)), 1, "test4_recursion_misses");
+       ASSERT_GE(get_missed_count(bpf_program__fd(skel->progs.test5)), 1, "test5_recursion_misses");
 
 cleanup:
        missed_kprobe_recursion__destroy(skel);