]> www.infradead.org Git - users/hch/misc.git/commitdiff
mfd: ls2kbmc: Fix an IS_ERR() vs NULL check in probe()
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 3 Oct 2025 09:29:09 +0000 (12:29 +0300)
committerCorey Minyard <corey@minyard.net>
Fri, 3 Oct 2025 15:38:17 +0000 (10:38 -0500)
The devm_kzalloc() function returns NULL on error so check for that
instead of error pointers.

Fixes: d952bba3fbb5 ("mfd: ls2kbmc: Add Loongson-2K BMC reset function support")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Message-ID: <df80c6d61229eb8f877c3694525c0f97e64a43e8.1759478975.git.dan.carpenter@linaro.org>
Signed-off-by: Corey Minyard <corey@minyard.net>
drivers/mfd/ls2k-bmc-core.c

index e162b3c7c9f8219abbb2c638179e9f320645b132..5f38514fa89e1a9463b84eb3a9ad0bcb42b2f1a6 100644 (file)
@@ -469,7 +469,7 @@ static int ls2k_bmc_probe(struct pci_dev *dev, const struct pci_device_id *id)
                return ret;
 
        ddata = devm_kzalloc(&dev->dev, sizeof(*ddata), GFP_KERNEL);
-       if (IS_ERR(ddata)) {
+       if (!ddata) {
                ret = -ENOMEM;
                goto disable_pci;
        }