i2c: k1: Initialize variable before use

Commit 95a8ca229032 ("i2c: spacemit: add support for SpacemiT K1
SoC") introduced a check in the probe function to warn the user
if the DTS has incorrect frequency settings. In such cases, the
driver falls back to default values.

However, the return value of of_property_read_u32() was not
stored, making the check ineffective. Fix this by storing the
return value in 'ret' and evaluating it properly.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202503200928.eBWfwnHG-lkp@intel.com/
Cc: Troy Mitchell <troymitchell988@gmail.com>
Link: https://lore.kernel.org/r/20250320113521.3966762-1-andi.shyti@kernel.org
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>

diff --git a/drivers/i2c/busses/i2c-k1.c b/drivers/i2c/busses/i2c-k1.c
index 0d8763b852db9829c6d5adc0ee99c1f3d8176290..5965b4cf6220e43c3db5add69ed48191ceb2d767 100644 (file)
--- a/drivers/i2c/busses/i2c-k1.c
+++ b/drivers/i2c/busses/i2c-k1.c
@@ -514,7 +514,7 @@ static int spacemit_i2c_probe(struct platform_device *pdev)
        if (!i2c)
                return -ENOMEM;
 
-       of_property_read_u32(of_node, "clock-frequency", &i2c->clock_freq);
+       ret = of_property_read_u32(of_node, "clock-frequency", &i2c->clock_freq);
        if (ret && ret != -EINVAL)
                dev_warn(dev, "failed to read clock-frequency property: %d\n", ret);